You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by GitBox <gi...@apache.org> on 2021/05/03 04:06:34 UTC

[GitHub] [drill] luocooong opened a new pull request #2213: DRILL-7913: Improve the tips using the Tooltips

luocooong opened a new pull request #2213:
URL: https://github.com/apache/drill/pull/2213


   # [DRILL-7913](https://issues.apache.org/jira/browse/DRILL-7913): Improve the tips using the Tooltips
   
   ## Description
   
   Actually, the tips of web console is hard to use.
   
   1. Too slowly (Delay 2s +)
   2. No good for the readable (Font size and bg color)
   
   Based on the Bootstrap (existed) and Popper.js (new), Use the new module [Tooltips](https://getbootstrap.com/docs/4.0/components/tooltips/) to improve these. 
   
   ## Documentation
   N/A
   
   ## Testing
   ![image](https://user-images.githubusercontent.com/50079619/116840144-64c03a00-ac07-11eb-852a-3cd5f760d114.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [drill] luocooong merged pull request #2213: DRILL-7913: Improve the tips using the Tooltips

Posted by GitBox <gi...@apache.org>.
luocooong merged pull request #2213:
URL: https://github.com/apache/drill/pull/2213


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [drill] luocooong commented on pull request #2213: DRILL-7913: Improve the tips using the Tooltips

Posted by GitBox <gi...@apache.org>.
luocooong commented on pull request #2213:
URL: https://github.com/apache/drill/pull/2213#issuecomment-832351423


   @cgivre Done. And I have updated the description for the library upgrade. thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [drill] cgivre commented on pull request #2213: DRILL-7913: Improve the tips using the Tooltips

Posted by GitBox <gi...@apache.org>.
cgivre commented on pull request #2213:
URL: https://github.com/apache/drill/pull/2213#issuecomment-832047828


   @luocooong 
   This looks great!  As a part of this PR, could you update jquery to v 3.6.0?  There are some CVEs associated with the version of jquery that we're currently using. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org