You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "1cbyc (via GitHub)" <gi...@apache.org> on 2026/10/16 04:12:27 UTC

[PR] refactor: extract aggregate physical planning [datafusion]

1cbyc opened a new pull request, #26403:
URL: https://github.com/apache/datafusion/pull/26403

   ## Which issue does this PR close?
   
   - Part of #26300.
   
   ## Rationale for this change
   
   `DefaultPhysicalPlanner::map_logical_node_to_physical` contains the complete aggregate planning implementation inline. Moving this arm behind a focused method makes the top-level logical-plan dispatcher easier to navigate and reduces conflict pressure around planner changes.
   
   ## What changes are included in this PR?
   
   This PR extracts only the `Aggregate` arm into a private `plan_aggregate` method. Schema validation, grouping expression lowering, async expression planning, repartition selection, and partial/final aggregate construction are unchanged.
   
   ## What is the testing strategy for this PR?
   
   - `cargo test -p datafusion --lib physical_planner::tests`
   - `cargo clippy -p datafusion --all-targets --all-features -- -D warnings`
   - `cargo fmt --all -- --check`
   - `git diff --check`
   
   The existing physical planner tests cover aggregate schema checks, grouping sets, repartitioning, aliases, and scalar subqueries; no new behavior is introduced.
   
   ## Are there any user-facing changes?
   
   No. This is an internal refactor with no public API or behavior change.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] refactor: extract aggregate physical planning [datafusion]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #26403:
URL: https://github.com/apache/datafusion/pull/26403#issuecomment-6209016605

   ## [Codecov](https://app.codecov.io/gh/apache/datafusion/pull/26403?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `96.29630%` with `6 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 82.87%. Comparing base ([`5009f42`](https://app.codecov.io/gh/apache/datafusion/commit/5009f42e4a24d231580222e5628c1e203f07614b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`23a4cd8`](https://app.codecov.io/gh/apache/datafusion/commit/23a4cd809e86f4e91f8ab12ea1f99ff54cb6356d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/datafusion/pull/26403?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [datafusion/core/src/physical\_planner.rs](https://app.codecov.io/gh/apache/datafusion/pull/26403?src=pr&el=tree&filepath=datafusion%2Fcore%2Fsrc%2Fphysical_planner.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZGF0YWZ1c2lvbi9jb3JlL3NyYy9waHlzaWNhbF9wbGFubmVyLnJz) | 96.29% | [4 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/datafusion/pull/26403?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@           Coverage Diff           @@
   ##             main   #26403   +/-   ##
   =======================================
     Coverage   82.87%   82.87%           
   =======================================
     Files        1153     1153           
     Lines      457101   457124   +23     
     Branches   457101   457124   +23     
   =======================================
   + Hits       378818   378841   +23     
   + Misses      55268    55267    -1     
   - Partials    23015    23016    +1     
   ```
   </details>
   
   [:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/datafusion/pull/26403?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] refactor: extract aggregate physical planning [datafusion]

Posted by "2010YOUY01 (via GitHub)" <gi...@apache.org>.
2010YOUY01 merged PR #26403:
URL: https://github.com/apache/datafusion/pull/26403


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org