You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by guoxiaolongzte <gi...@git.apache.org> on 2017/03/31 13:04:37 UTC
[GitHub] spark pull request #17497: [SPARK-20177]Document about compression way has s...
GitHub user guoxiaolongzte opened a pull request:
https://github.com/apache/spark/pull/17497
[SPARK-20177]Document about compression way has some little detail changes.
## What changes were proposed in this pull request?
Document compression way little detail changes.
1.spark.eventLog.compress add 'Compression will use spark.io.compression.codec.'
2.spark.broadcast.compress add 'Compression will use spark.io.compression.codec.'
3,spark.rdd.compress add 'Compression will use spark.io.compression.codec.'
4.spark.io.compression.codec add 'event log describe'
## How was this patch tested?
manual tests
Please review http://spark.apache.org/contributing.html before opening a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/guoxiaolongzte/spark SPARK-20177
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/17497.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #17497
----
commit b9fc187db8be52631712136f1fa2f9bd0cb978e2
Author: \u90ed\u5c0f\u9f99 10207633 <gu...@zte.com.cn>
Date: 2017-03-09T01:14:54Z
remove tungsten-sort.Because it is not represent 'org.apache.spark.shuffle.unsafe.UnsafeShuffleManager'.
commit 1106bff8a620d3b71fe078a25080d45d9f3eec0d
Author: \u90ed\u5c0f\u9f99 10207633 <gu...@zte.com.cn>
Date: 2017-03-31T06:38:13Z
Merge branch 'master' of https://github.com/apache/spark into SPARK-19862
commit 1efb8f37acc9d12e86a38240625400539a848f18
Author: \u90ed\u5c0f\u9f99 10207633 <gu...@zte.com.cn>
Date: 2017-03-31T12:59:05Z
Document about compression way has some little detail changes.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #17497: [SPARK-20177]Document about compression way has s...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/17497#discussion_r109158545
--- Diff: docs/configuration.md ---
@@ -773,14 +774,15 @@ Apart from these, the following properties are also available, and may be useful
<td>true</td>
<td>
Whether to compress broadcast variables before sending them. Generally a good idea.
+ Compression will use spark.io.compression.codec.
--- End diff --
Back-tick these.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17497: [SPARK-20177]Document about compression way has some lit...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17497
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #17497: [SPARK-20177]Document about compression way has s...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/17497#discussion_r109158570
--- Diff: docs/configuration.md ---
@@ -773,14 +774,15 @@ Apart from these, the following properties are also available, and may be useful
<td>true</td>
<td>
Whether to compress broadcast variables before sending them. Generally a good idea.
+ Compression will use spark.io.compression.codec.
</td>
</tr>
<tr>
<td><code>spark.io.compression.codec</code></td>
<td>lz4</td>
<td>
- The codec used to compress internal data such as RDD partitions, broadcast variables and
- shuffle outputs. By default, Spark provides three codecs: <code>lz4</code>, <code>lzf</code>,
+ The codec used to compress internal data such as RDD partitions,event log,broadcast variables
--- End diff --
Space after comma
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #17497: [SPARK-20177]Document about compression way has s...
Posted by guoxiaolongzte <gi...@git.apache.org>.
Github user guoxiaolongzte closed the pull request at:
https://github.com/apache/spark/pull/17497
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org