Python distribution

[Jon Malkin <jo...@gmail.com>]

Hi everyone, especially mentors.

One part of the motivation for the C++ sketches implementation is that we
can create efficient python bindings. I managed to finish building a python
package, and even figured out how to get it into pypi so we can use pip to
install it by name. But I have a few questions.

1) I'm assuming that pushing a python package will follow the regular
release process, which in this case means gating it on a formal C++ release
before we make a package available? (I've only uploaded to a pypi test
server so I could ensure I had things working properly, not the real one.)

2) The wrapper depends on pybind11, which is open source but based on a BSD
license. The example they provide for using pybind11 in a C++ project
creates a git submodule that points to the pybind11 git rep. And to make a
self-contained package, that directory would be included in our source
distribution. Is that ok? I don't know how including a BSD-licensed project
like that plays with the Apache license.

  jon

Re: Python distribution

[Kenneth Knowles <ke...@apache.org>]

1) I am not sure I understand the technical details of the proposed
processed. The main thing is that you must only characterize things as
released Apache software if there has actually been a release, including
vote. So upload the pypi artifact "apache-datasketches-x.y.z-incubating"
from the voted x.y.z release.

2) See https://www.apache.org/legal/resolved.html#category-a which includes
BSD 3 clause. Here is an example of the additions to LICENSE that have been
made for a BSD 3 clause dependency:
https://github.com/apache/beam/blob/master/LICENSE#L339.

On Tue, Jul 9, 2019 at 12:54 PM Jon Malkin <jo...@gmail.com> wrote:

> Hi everyone, especially mentors.
>
> One part of the motivation for the C++ sketches implementation is that we
> can create efficient python bindings. I managed to finish building a python
> package, and even figured out how to get it into pypi so we can use pip to
> install it by name. But I have a few questions.
>
> 1) I'm assuming that pushing a python package will follow the regular
> release process, which in this case means gating it on a formal C++ release
> before we make a package available? (I've only uploaded to a pypi test
> server so I could ensure I had things working properly, not the real one.)
>
> 2) The wrapper depends on pybind11, which is open source but based on a BSD
> license. The example they provide for using pybind11 in a C++ project
> creates a git submodule that points to the pybind11 git rep. And to make a
> self-contained package, that directory would be included in our source
> distribution. Is that ok? I don't know how including a BSD-licensed project
> like that plays with the Apache license.
>
>   jon
>