[GitHub] [pinot] saurabhd336 commented on a diff in pull request #8582: Support conjugates for scalar functions, add more scalar functions

[GitBox <gi...@apache.org>]

saurabhd336 commented on code in PR #8582:
URL: https://github.com/apache/pinot/pull/8582#discussion_r862453302


##########
pinot-segment-local/src/test/java/org/apache/pinot/segment/local/recordtransformer/RecordTransformerTest.java:
##########
@@ -178,6 +178,29 @@ public void testSanitationTransformer() {
     }
   }
 
+  @Test
+  public void testLogicalScalarOps() {
+    TableConfig tableConfig = new TableConfigBuilder(TableType.OFFLINE).setTableName("testTable").build();
+
+    // expression true, filtered
+    GenericRow genericRow = getRecord();
+    tableConfig.setIngestionConfig(
+        new IngestionConfig(null, null,
+            new FilterConfig("AND(EQUALS(svInt, 123), LESS_THAN_OR_EQUAL(svDouble, 200))"), null, null));

Review Comment:
   ack



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org