You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@isis.apache.org by GitBox <gi...@apache.org> on 2021/02/21 19:40:24 UTC
[GitHub] [isis] joonatan-r opened a new pull request #393: ISIS-1922: Notify user when expired session is refreshed
joonatan-r opened a new pull request #393:
URL: https://github.com/apache/isis/pull/393
Without this patch applied, when a user clicks a menu item in an expired
session, the session is simply refreshed and no action is taken. This is
a problem because from the user's point of view the click is ignored. This
patch fixes the problem by notifying user that the session was expired and
was refreshed from the click.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [isis] andi-huber merged pull request #393: ISIS-1922: Notify user when expired session is refreshed
Posted by GitBox <gi...@apache.org>.
andi-huber merged pull request #393:
URL: https://github.com/apache/isis/pull/393
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [isis] andi-huber commented on pull request #393: ISIS-1922: Notify user when expired session is refreshed
Posted by GitBox <gi...@apache.org>.
andi-huber commented on pull request #393:
URL: https://github.com/apache/isis/pull/393#issuecomment-783168781
Hi @joonatan-r - From a first glance, looks very promising. Your code comments help me quite a bit to understand the intent. I'll need some time to actually test it out (by this week).
As this is the 3rd PR within a few day against Apache Isis, I wonder why of a sudden, we get so many code contributions. And are there expected to be more?
Also my apologies, that presumable quite a bunch of (still) open Jira tickets potentially can be closed as 'won't fix'. Hence, as @danhaywood already commented on the previous PRs, we encourage you to coordinate with us before working on a ticket. That should prevent waste of time and energy. However, fixing ISIS-1922 is highly appreciated.
Best ways to coordinate with us are, either comment on the Jira tickets in question, or join our Slack chat, where I assure you we have a very welcoming community. See the contact section of our official site for details: https://isis.apache.org/#contact
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [isis] joonatan-r commented on pull request #393: ISIS-1922: Notify user when expired session is refreshed
Posted by GitBox <gi...@apache.org>.
joonatan-r commented on pull request #393:
URL: https://github.com/apache/isis/pull/393#issuecomment-783505461
Hi @andi-huber ! This PR is a part of a course project where we had to make a pull request to an open source project. The other PRs are most likely from other students from this course, so it's possible that there will be some more. Thank you for the informative comment!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [isis] andi-huber commented on pull request #393: ISIS-1922: Notify user when expired session is refreshed
Posted by GitBox <gi...@apache.org>.
andi-huber commented on pull request #393:
URL: https://github.com/apache/isis/pull/393#issuecomment-783506650
I see, well good choice! Thanks for letting me know.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org