You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Daryn Sharp (JIRA)" <ji...@apache.org> on 2011/06/10 21:36:59 UTC
[jira] [Created] (HADOOP-7377) Fix command name handling affecting
DFSAdmin
Fix command name handling affecting DFSAdmin
--------------------------------------------
Key: HADOOP-7377
URL: https://issues.apache.org/jira/browse/HADOOP-7377
Project: Hadoop Common
Issue Type: Bug
Components: fs
Affects Versions: 0.23.0
Reporter: Daryn Sharp
Assignee: Daryn Sharp
When an error occurs in the get/set quota commands in DFSAdmin, they are displaying the following:
setQuota: failed to get SetQuotaCommand.NAME
The {{Command}} class expects the {{NAME}} field to be accessible, but for DFSAdmin, it's not.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7377) Fix command name handling
affecting DFSAdmin
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13047426#comment-13047426 ]
Hadoop QA commented on HADOOP-7377:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12482092/HADOOP-7377.patch
against trunk revision 1134218.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/610//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/610//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/610//console
This message is automatically generated.
> Fix command name handling affecting DFSAdmin
> --------------------------------------------
>
> Key: HADOOP-7377
> URL: https://issues.apache.org/jira/browse/HADOOP-7377
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.23.0
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Attachments: HADOOP-7377.patch
>
>
> When an error occurs in the get/set quota commands in DFSAdmin, they are displaying the following:
> setQuota: failed to get SetQuotaCommand.NAME
> The {{Command}} class expects the {{NAME}} field to be accessible, but for DFSAdmin, it's not.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7377) Fix command name handling affecting
DFSAdmin
Posted by "Daryn Sharp (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daryn Sharp updated HADOOP-7377:
--------------------------------
Attachment: HADOOP-7377.patch
Quick cheap way to get the NAME field despite the visibility of the class and/or field.
> Fix command name handling affecting DFSAdmin
> --------------------------------------------
>
> Key: HADOOP-7377
> URL: https://issues.apache.org/jira/browse/HADOOP-7377
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.23.0
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Attachments: HADOOP-7377.patch
>
>
> When an error occurs in the get/set quota commands in DFSAdmin, they are displaying the following:
> setQuota: failed to get SetQuotaCommand.NAME
> The {{Command}} class expects the {{NAME}} field to be accessible, but for DFSAdmin, it's not.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7377) Fix command name handling
affecting DFSAdmin
Posted by "Daryn Sharp (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13049429#comment-13049429 ]
Daryn Sharp commented on HADOOP-7377:
-------------------------------------
This patch fixes all of the failing negative tests for {{DFSAdmin}} in {{TestHDFSCLI}}. As of build #777, the negative {{DFSAdmin}} tests are the only tests that are failing in {{TestHDFSCLI}}.
> Fix command name handling affecting DFSAdmin
> --------------------------------------------
>
> Key: HADOOP-7377
> URL: https://issues.apache.org/jira/browse/HADOOP-7377
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.23.0
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Attachments: HADOOP-7377.patch
>
>
> When an error occurs in the get/set quota commands in DFSAdmin, they are displaying the following:
> setQuota: failed to get SetQuotaCommand.NAME
> The {{Command}} class expects the {{NAME}} field to be accessible, but for DFSAdmin, it's not.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7377) Fix command name handling affecting
DFSAdmin
Posted by "Daryn Sharp (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daryn Sharp updated HADOOP-7377:
--------------------------------
Status: Patch Available (was: Open)
No tests included because it fixes tests in hdfs.
> Fix command name handling affecting DFSAdmin
> --------------------------------------------
>
> Key: HADOOP-7377
> URL: https://issues.apache.org/jira/browse/HADOOP-7377
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.23.0
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Attachments: HADOOP-7377.patch
>
>
> When an error occurs in the get/set quota commands in DFSAdmin, they are displaying the following:
> setQuota: failed to get SetQuotaCommand.NAME
> The {{Command}} class expects the {{NAME}} field to be accessible, but for DFSAdmin, it's not.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7377) Fix command name handling affecting
DFSAdmin
Posted by "Matt Foley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matt Foley updated HADOOP-7377:
-------------------------------
Resolution: Fixed
Fix Version/s: 0.23.0
Status: Resolved (was: Patch Available)
No it doesn't need to be rebased.
Committed to trunk. Thanks, Daryn!
> Fix command name handling affecting DFSAdmin
> --------------------------------------------
>
> Key: HADOOP-7377
> URL: https://issues.apache.org/jira/browse/HADOOP-7377
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.23.0
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Fix For: 0.23.0
>
> Attachments: HADOOP-7377.patch
>
>
> When an error occurs in the get/set quota commands in DFSAdmin, they are displaying the following:
> setQuota: failed to get SetQuotaCommand.NAME
> The {{Command}} class expects the {{NAME}} field to be accessible, but for DFSAdmin, it's not.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7377) Fix command name handling
affecting DFSAdmin
Posted by "Matt Foley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13049351#comment-13049351 ]
Matt Foley commented on HADOOP-7377:
------------------------------------
I'm uncomfortable using reflection with access permission override, to get a datum that seems like it could be fetched using provided methods such as getCommandName(). However, Daryn has convinced me that it would require a massive change of legacy code to make this better:
bq. [Daryn] The CommandFactory is supposed to call setName(...) on the instance it creates, using the name fed to the factory (since commands can have more than one invokable name). setName()/getName() should be just using the instance field name. The static NAME is legacy and was not intended to remain. But Count and the DFSAdmin commands, unfortunately, use it. I intend to kill both getCommandName() and NAME, if possible, after DFSAdmin is adapted to better use the framework. Basically, the command should not know it's name, that's the factory's job, and the factory tells the command how it was conjured up. But in the meantime, NAME is needed.
So, +1 on this patch.
Auto-test passes except for new test, but this patch will be tested by existing DFSAdmin unit tests starting to work.
I'll commit this in 24 hours to allow for other comments.
Daryn, please list the exact unit tests that will be fixed by this submission. Thanks.
> Fix command name handling affecting DFSAdmin
> --------------------------------------------
>
> Key: HADOOP-7377
> URL: https://issues.apache.org/jira/browse/HADOOP-7377
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.23.0
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Attachments: HADOOP-7377.patch
>
>
> When an error occurs in the get/set quota commands in DFSAdmin, they are displaying the following:
> setQuota: failed to get SetQuotaCommand.NAME
> The {{Command}} class expects the {{NAME}} field to be accessible, but for DFSAdmin, it's not.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7377) Fix command name handling
affecting DFSAdmin
Posted by "Matt Foley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13049939#comment-13049939 ]
Matt Foley commented on HADOOP-7377:
------------------------------------
This patch needs to be rebased for trunk.
> Fix command name handling affecting DFSAdmin
> --------------------------------------------
>
> Key: HADOOP-7377
> URL: https://issues.apache.org/jira/browse/HADOOP-7377
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.23.0
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Attachments: HADOOP-7377.patch
>
>
> When an error occurs in the get/set quota commands in DFSAdmin, they are displaying the following:
> setQuota: failed to get SetQuotaCommand.NAME
> The {{Command}} class expects the {{NAME}} field to be accessible, but for DFSAdmin, it's not.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7377) Fix command name handling
affecting DFSAdmin
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13050100#comment-13050100 ]
Hudson commented on HADOOP-7377:
--------------------------------
Integrated in Hadoop-Common-trunk-Commit #657 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/657/])
HADOOP-7377. Fix command name handling affecting DFSAdmin. Contributed by Daryn Sharp.
mattf : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1136223
Files :
* /hadoop/common/trunk/common/src/java/org/apache/hadoop/fs/shell/Command.java
* /hadoop/common/trunk/common/CHANGES.txt
> Fix command name handling affecting DFSAdmin
> --------------------------------------------
>
> Key: HADOOP-7377
> URL: https://issues.apache.org/jira/browse/HADOOP-7377
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.23.0
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Fix For: 0.23.0
>
> Attachments: HADOOP-7377.patch
>
>
> When an error occurs in the get/set quota commands in DFSAdmin, they are displaying the following:
> setQuota: failed to get SetQuotaCommand.NAME
> The {{Command}} class expects the {{NAME}} field to be accessible, but for DFSAdmin, it's not.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7377) Fix command name handling
affecting DFSAdmin
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13057101#comment-13057101 ]
Hudson commented on HADOOP-7377:
--------------------------------
Integrated in Hadoop-Common-trunk-maven #43 (See [https://builds.apache.org/job/Hadoop-Common-trunk-maven/43/])
> Fix command name handling affecting DFSAdmin
> --------------------------------------------
>
> Key: HADOOP-7377
> URL: https://issues.apache.org/jira/browse/HADOOP-7377
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.23.0
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Fix For: 0.23.0
>
> Attachments: HADOOP-7377.patch
>
>
> When an error occurs in the get/set quota commands in DFSAdmin, they are displaying the following:
> setQuota: failed to get SetQuotaCommand.NAME
> The {{Command}} class expects the {{NAME}} field to be accessible, but for DFSAdmin, it's not.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira