You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2021/03/26 11:30:43 UTC

[GitHub] [cordova-android] mosabab commented on pull request #1097: [Gradle Syncs] Gradle 6.8.3 & Android Gradle Plugin 4.1.3 & Kotlin 1.4.31

mosabab commented on pull request #1097:
URL: https://github.com/apache/cordova-android/pull/1097#issuecomment-808140596


   > I want this single PR to be split up into two or three separate PRs.
   > 
   > 1. `feat: upgrade gradle@6.8.3`
   > 2. `feat: upgrade gradle-plugin@4.1.3`
   > 3. `feat: upgrade kotlin@1.4.31`
   > 
   > We generally squash merge PRs. Also if we need to revert a change because of issues, we will revert the entire PR. This means everything will be dropped.
   > 
   > IMO, seeing that these changes only updates to the latest minor release, it should be safe to be in the next minor release.
   > 
   > Also, I do not see why this PR contains code changes in `CordovaWebViewImpl.java` for this type of PR. It should be removed. I suspect because your not creating branches for your work your mixing to many things.
   
   Thanks for explain!
   Done


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org