You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "kou (via GitHub)" <gi...@apache.org> on 2023/07/28 01:46:33 UTC

[GitHub] [arrow] kou commented on a diff in pull request #36901: GH-15017: [Python] Harden test_memory.py for use with ARROW_USE_GLOG=ON

kou commented on code in PR #36901:
URL: https://github.com/apache/arrow/pull/36901#discussion_r1276995625


##########
python/pyarrow/tests/test_memory.py:
##########
@@ -134,8 +134,14 @@ def check_env_var(name, expected, *, expect_warning=False):
         res.check_returncode()  # fail
     errlines = res.stderr.splitlines()
     if expect_warning:
-        assert len(errlines) == 1
-        assert f"Unsupported backend '{name}'" in errlines[0]
+        assert len(errlines) in (1, 2)
+        if len(errlines) == 1:
+            # ARROW_USE_GLOG=OFF
+            assert f"Unsupported backend '{name}'" in errlines[0]
+        else:
+            # ARROW_USE_GLOG=ON
+            assert f"InitGoogleLogging()" in errlines[0]

Review Comment:
   ```suggestion
               assert "InitGoogleLogging()" in errlines[0]
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org