You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2022/09/22 17:29:01 UTC
[GitHub] [lucene] caohassl opened a new pull request, #11806: GITHUB#11728: Add a InterruptedCollector to received thread interrupt request and exit search task early
caohassl opened a new pull request, #11806:
URL: https://github.com/apache/lucene/pull/11806
### Description
ISSUE:#11805
1、Add a InterruptedCollector class to delegate collector
2、By default, when LeafReaderContext is traversed, determine whether there is an interrupt request.
3、Optionally, when document is collected, determine if there is an interrupt request
Throw an SearchInterruptedException to exit if search threads receive an interrupt request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] uschindler commented on pull request #11806: GITHUB#11728: Add a InterruptedCollector to received thread interrupt request and exit search task early
Posted by GitBox <gi...@apache.org>.
uschindler commented on PR #11806:
URL: https://github.com/apache/lucene/pull/11806#issuecomment-1257216396
This won't work when the thread is blocked on I/O (e.g. when it reads from IndexInput). Java has the behaviour to close file handles for safety when a thread doing IO was interrupted. When you use this collector the file handle might get closed.
This won't negatively affect MMapDirectory (unless you interrupt at the time of opening the file), but all other implementations will fail.
So we won't merge this. See also @rmuir 's comment in #11728.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] uschindler closed pull request #11806: GITHUB#11805: Add a InterruptedCollector to received thread interrupt request and exit search task early
Posted by GitBox <gi...@apache.org>.
uschindler closed pull request #11806: GITHUB#11805: Add a InterruptedCollector to received thread interrupt request and exit search task early
URL: https://github.com/apache/lucene/pull/11806
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org