You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by "Charles Overbeck (JIRA)" <ji...@apache.org> on 2008/10/03 20:24:44 UTC

[jira] Created: (GERONIMODEVTOOLS-522) Feature.properties has a trailing backslash in it

Feature.properties has a trailing backslash in it
-------------------------------------------------

                 Key: GERONIMODEVTOOLS-522
                 URL: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-522
             Project: Geronimo-Devtools
          Issue Type: Bug
          Components: eclipse-plugin
    Affects Versions: 2.1.3
            Reporter: Charles Overbeck
            Assignee: Tim McConnell


The feature.properties on the update site bundled with org.apache.geronimo.v21.feature_2.1.3.jar has a trailing backslash in it. The last two lines of the file are this:

trial in any resulting litigation. \n\
\n\ 

Note the trailing slash at the end of the second line; no characters follow it. This may not sound like a terrible bug on its own, but because that content ends up getting expanded inside the feature.xml, I think it escapes the next character in the feature.xml, which in this case is the "<" which closes a tag. This leads to an incorrectly generated content.xml file if you are generating an update site using Eclipse's P2 metadata generator, and you have the Geronimo feature present when you are doing the metadata generation. I don't know if it has any other side-effects.

In any case, that's why I'm proposing a priority of Major for this seeming trivial bug.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (GERONIMODEVTOOLS-522) Feature.properties has a trailing backslash in it

Posted by "Ted Kirby (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ted Kirby resolved GERONIMODEVTOOLS-522.
----------------------------------------

       Resolution: Fixed
    Fix Version/s: 2.1.4
                   2.2.0
         Assignee: Ted Kirby  (was: Tim McConnell)

It looks like we can't redo a released artifact.  We will do a 214 release, and I added this fix to it in rev 702578.

> Feature.properties has a trailing backslash in it
> -------------------------------------------------
>
>                 Key: GERONIMODEVTOOLS-522
>                 URL: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-522
>             Project: Geronimo-Devtools
>          Issue Type: Bug
>          Components: eclipse-plugin
>    Affects Versions: 2.1.3
>            Reporter: Charles Overbeck
>            Assignee: Ted Kirby
>             Fix For: 2.2.0, 2.1.4
>
>
> The feature.properties on the update site bundled with org.apache.geronimo.v21.feature_2.1.3.jar has a trailing backslash in it. The last two lines of the file are this:
> trial in any resulting litigation. \n\
> \n\ 
> Note the trailing slash at the end of the second line; no characters follow it. This may not sound like a terrible bug on its own, but because that content ends up getting expanded inside the feature.xml, I think it escapes the next character in the feature.xml, which in this case is the "<" which closes a tag. This leads to an incorrectly generated content.xml file if you are generating an update site using Eclipse's P2 metadata generator, and you have the Geronimo feature present when you are doing the metadata generation. I don't know if it has any other side-effects.
> In any case, that's why I'm proposing a priority of Major for this seeming trivial bug.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Re: [jira] Commented: (GERONIMODEVTOOLS-522) Feature.properties has a trailing backslash in it

Posted by Donald Woods <dw...@apache.org>.
We don't re-release prior artifacts.  To incorporate any new fixes, 
you'd have to create a GEP 2.1.4 release.

BTW - There will be a 2.1.4 Server release sometime in 4Q08 or 1Q09, as 
there have been several useful/important fixes since 2.1.3 and several 
JIRAs that need to be addressed for users who don't want to move to 2.2 
right away.....


-Donald


Ted Kirby (JIRA) wrote:
>     [ https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12636776#action_12636776 ] 
> 
> Ted Kirby commented on GERONIMODEVTOOLS-522:
> --------------------------------------------
> 
> Thanks for bug report.  I fixed it in trunk with rev 701571.  We would like to work better in p2, and have had some issues with it.
> 
> I don't know if we will do a 2.1.4.  Currently trunk is targeted to 2.2.
> 
> I wonder if we could or should fix this in 2.1.3 and put new artifacts on our eclipse plugin update site?
> 
>> Feature.properties has a trailing backslash in it
>> -------------------------------------------------
>>
>>                 Key: GERONIMODEVTOOLS-522
>>                 URL: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-522
>>             Project: Geronimo-Devtools
>>          Issue Type: Bug
>>          Components: eclipse-plugin
>>    Affects Versions: 2.1.3
>>            Reporter: Charles Overbeck
>>            Assignee: Tim McConnell
>>
>> The feature.properties on the update site bundled with org.apache.geronimo.v21.feature_2.1.3.jar has a trailing backslash in it. The last two lines of the file are this:
>> trial in any resulting litigation. \n\
>> \n\ 
>> Note the trailing slash at the end of the second line; no characters follow it. This may not sound like a terrible bug on its own, but because that content ends up getting expanded inside the feature.xml, I think it escapes the next character in the feature.xml, which in this case is the "<" which closes a tag. This leads to an incorrectly generated content.xml file if you are generating an update site using Eclipse's P2 metadata generator, and you have the Geronimo feature present when you are doing the metadata generation. I don't know if it has any other side-effects.
>> In any case, that's why I'm proposing a priority of Major for this seeming trivial bug.
> 

[jira] Commented: (GERONIMODEVTOOLS-522) Feature.properties has a trailing backslash in it

Posted by "Ted Kirby (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12636776#action_12636776 ] 

Ted Kirby commented on GERONIMODEVTOOLS-522:
--------------------------------------------

Thanks for bug report.  I fixed it in trunk with rev 701571.  We would like to work better in p2, and have had some issues with it.

I don't know if we will do a 2.1.4.  Currently trunk is targeted to 2.2.

I wonder if we could or should fix this in 2.1.3 and put new artifacts on our eclipse plugin update site?

> Feature.properties has a trailing backslash in it
> -------------------------------------------------
>
>                 Key: GERONIMODEVTOOLS-522
>                 URL: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-522
>             Project: Geronimo-Devtools
>          Issue Type: Bug
>          Components: eclipse-plugin
>    Affects Versions: 2.1.3
>            Reporter: Charles Overbeck
>            Assignee: Tim McConnell
>
> The feature.properties on the update site bundled with org.apache.geronimo.v21.feature_2.1.3.jar has a trailing backslash in it. The last two lines of the file are this:
> trial in any resulting litigation. \n\
> \n\ 
> Note the trailing slash at the end of the second line; no characters follow it. This may not sound like a terrible bug on its own, but because that content ends up getting expanded inside the feature.xml, I think it escapes the next character in the feature.xml, which in this case is the "<" which closes a tag. This leads to an incorrectly generated content.xml file if you are generating an update site using Eclipse's P2 metadata generator, and you have the Geronimo feature present when you are doing the metadata generation. I don't know if it has any other side-effects.
> In any case, that's why I'm proposing a priority of Major for this seeming trivial bug.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.