[jira] [Commented] (TS-3156) Mutex[Try]Lock bool() operator change and unused API removal

["Ryo Okubo (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TS-3156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14201863#comment-14201863 ] 

Ryo Okubo commented on TS-3156:
-------------------------------

I found a bug which raised SIGABRT after applying [53e56ffc7499648bc096d63f9c0f9da0ea9212ba|https://github.com/apache/trafficserver/commit/53e56ffc7499648bc096d63f9c0f9da0ea9212ba]

When I specified multiple ports for ssl:
{noformat}
CONFIG proxy.config.http.server_ports STRING 443:ssl 4430:ssl
{noformat}

then I caught the below problem.
{noformat}
#0  0x0000003e06232925 in raise () from /lib64/libc.so.6
#1  0x0000003e06234105 in abort () from /lib64/libc.so.6
#2  0x00000000004f5cd2 in ink_mutex_acquire (m=0xac76d0) at ../lib/ts/ink_mutex.h:94
#3  0x00000000004f8482 in Mutex_lock (afile=0x7aa937 "HttpProxyServerMain.cc", aline=227, ahandler=0x0, m=0xac76c0, t=0x7ffff6225010) at ../iocore/eventsystem/I_Lock.h:392
#4  0x0000000000520e3a in MutexLock::MutexLock (this=0x7fffffffe3b0, afile=0x7aa937 "HttpProxyServerMain.cc", aline=227, ahandler=0x0, am=0xac76c0, t=0x7ffff6225010) at ../iocore/eventsystem/I_Lock.h:459
#5  0x00000000005ce9e2 in MakeHttpProxyAcceptor (acceptor=..., port=..., nthreads=1) at HttpProxyServerMain.cc:227
#6  0x00000000005cebf5 in init_HttpProxyServer (n_accept_threads=1) at HttpProxyServerMain.cc:270
#7  0x000000000052ad9d in main (argv=0x7fffffffe7a8) at Main.cc:1554
{noformat}

> Mutex[Try]Lock bool() operator change and unused API removal
> ------------------------------------------------------------
>
>                 Key: TS-3156
>                 URL: https://issues.apache.org/jira/browse/TS-3156
>             Project: Traffic Server
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Powell Molleti
>            Assignee: James Peach
>            Priority: Minor
>              Labels: review
>             Fix For: 5.2.0
>
>         Attachments: MutexLock-ats.patch, MutexLock-ats.patch
>
>
> Removed unused constructor in MutexLock along with set_and_take() method, had to change FORCE_PLUGIN_MUTEX() for that. Removed release() method.
> default bool and ! operator from both MutexLock and MutexTryLock with is_locked() API. Changes if (lock) to if (lock.is_locked()) across the code base.
> Ran make test will be performing more system testing. Posted before for early comments / feedback.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)