You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@brooklyn.apache.org by he...@apache.org on 2016/09/26 10:37:56 UTC
[2/6] brooklyn-server git commit: logging for camp items leak
logging for camp items leak
Project: http://git-wip-us.apache.org/repos/asf/brooklyn-server/repo
Commit: http://git-wip-us.apache.org/repos/asf/brooklyn-server/commit/84aded4e
Tree: http://git-wip-us.apache.org/repos/asf/brooklyn-server/tree/84aded4e
Diff: http://git-wip-us.apache.org/repos/asf/brooklyn-server/diff/84aded4e
Branch: refs/heads/master
Commit: 84aded4e2c86fb34fe877d5159566c64c576b5cd
Parents: e947e92
Author: Alex Heneveld <al...@cloudsoftcorp.com>
Authored: Fri Sep 16 09:36:54 2016 +0100
Committer: Alex Heneveld <al...@cloudsoftcorp.com>
Committed: Fri Sep 16 16:53:19 2016 +0100
----------------------------------------------------------------------
.../brooklyn/camp/spi/collection/BasicResourceLookup.java | 9 +++++++++
1 file changed, 9 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/brooklyn-server/blob/84aded4e/camp/camp-base/src/main/java/org/apache/brooklyn/camp/spi/collection/BasicResourceLookup.java
----------------------------------------------------------------------
diff --git a/camp/camp-base/src/main/java/org/apache/brooklyn/camp/spi/collection/BasicResourceLookup.java b/camp/camp-base/src/main/java/org/apache/brooklyn/camp/spi/collection/BasicResourceLookup.java
index f1d3176..52850a6 100644
--- a/camp/camp-base/src/main/java/org/apache/brooklyn/camp/spi/collection/BasicResourceLookup.java
+++ b/camp/camp-base/src/main/java/org/apache/brooklyn/camp/spi/collection/BasicResourceLookup.java
@@ -24,9 +24,13 @@ import java.util.Map;
import org.apache.brooklyn.camp.spi.AbstractResource;
import org.apache.brooklyn.util.collections.MutableMap;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
public class BasicResourceLookup<T extends AbstractResource> extends AbstractResourceLookup<T> {
+ private static final Logger log = LoggerFactory.getLogger(BasicResourceLookup.class);
+
Map<String,T> items = new MutableMap<String,T>();
Map<String,ResolvableLink<T>> links = new MutableMap<String,ResolvableLink<T>>();
@@ -43,6 +47,11 @@ public class BasicResourceLookup<T extends AbstractResource> extends AbstractRes
if (old!=null) {
items.put(old.getId(), old);
throw new IllegalStateException("Already contains item for "+item.getId()+": "+old+" (adding "+item+")");
+ } else {
+ if (!items.isEmpty() && items.size()%100==0) {
+ // useful for monitoring any leaks here
+ log.debug("Creating new CAMP item in "+this+" (had "+(items.size())+"): "+item);
+ }
}
links.put(item.getId(), newLink(item.getId(), item.getName()));
}