You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@camel.apache.org by "orpiske (via GitHub)" <gi...@apache.org> on 2023/08/21 08:19:34 UTC

[GitHub] [camel] orpiske commented on pull request #11145: Camel-19557: added assertions to camel-core tests

orpiske commented on PR #11145:
URL: https://github.com/apache/camel/pull/11145#issuecomment-1685871778

   Regarding the first set of changes ... 
   
   I think catching an `AssertionError` is not an adequate test practice. That deviates from the actual purpose of the AssertionError which is to indicate that the test has failed. 
   
   For now, let's keep the original as is. Let's create a ticket on Apache Jira to note that this is a bad practice that must be fixed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org