You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@storm.apache.org by bo...@apache.org on 2016/03/24 21:38:05 UTC

[1/3] storm git commit: STORM-1625: Move storm-sql dependencies out of lib folder

Repository: storm
Updated Branches:
  refs/heads/master 73f6b5c88 -> d3182c46c


STORM-1625: Move storm-sql dependencies out of lib folder


Project: http://git-wip-us.apache.org/repos/asf/storm/repo
Commit: http://git-wip-us.apache.org/repos/asf/storm/commit/e461dc99
Tree: http://git-wip-us.apache.org/repos/asf/storm/tree/e461dc99
Diff: http://git-wip-us.apache.org/repos/asf/storm/diff/e461dc99

Branch: refs/heads/master
Commit: e461dc999afff00465bcc998bc53e3539074b0fe
Parents: ab66003
Author: Abhishek Agarwal <ab...@inmobi.com>
Authored: Sun Mar 20 16:24:20 2016 +0530
Committer: Abhishek Agarwal <ab...@inmobi.com>
Committed: Sun Mar 20 16:24:20 2016 +0530

----------------------------------------------------------------------
 bin/storm.py                                   |  5 ++++-
 external/sql/storm-sql-core/pom.xml            | 18 ++++++++++++++++++
 storm-dist/binary/pom.xml                      | 10 ----------
 storm-dist/binary/src/main/assembly/binary.xml |  4 ++--
 4 files changed, 24 insertions(+), 13 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/storm/blob/e461dc99/bin/storm.py
----------------------------------------------------------------------
diff --git a/bin/storm.py b/bin/storm.py
index 33fe026..2adbbb8 100755
--- a/bin/storm.py
+++ b/bin/storm.py
@@ -257,10 +257,13 @@ def sql(sql_file, topology_name):
 
     Compiles the SQL statements into a Trident topology and submits it to Storm.
     """
+    extrajars=[USER_CONF_DIR, STORM_BIN_DIR]
+    extrajars.extend(get_jars_full(STORM_DIR + "/external/sql/storm-sql-core"))
+    extrajars.extend(get_jars_full(STORM_DIR + "/external/sql/storm-sql-runtime"))
     exec_storm_class(
         "org.apache.storm.sql.StormSqlRunner",
         jvmtype="-client",
-        extrajars=[USER_CONF_DIR, STORM_BIN_DIR],
+        extrajars=extrajars,
         args=[sql_file, topology_name],
         daemon=False)
 

http://git-wip-us.apache.org/repos/asf/storm/blob/e461dc99/external/sql/storm-sql-core/pom.xml
----------------------------------------------------------------------
diff --git a/external/sql/storm-sql-core/pom.xml b/external/sql/storm-sql-core/pom.xml
index aa26762..aa85564 100644
--- a/external/sql/storm-sql-core/pom.xml
+++ b/external/sql/storm-sql-core/pom.xml
@@ -197,6 +197,24 @@
                     </execution>
                 </executions>
             </plugin>
+            <!-- using appassembler-maven-plugin instead of maven-dependency-plugin to copy dependencies
+            as copy and unpack goal are not working together -->
+            <plugin>
+                <groupId>org.codehaus.mojo</groupId>
+                <artifactId>appassembler-maven-plugin</artifactId>
+                <version>1.9</version>
+                <executions>
+                    <execution>
+                        <id>create-repo</id>
+                        <goals>
+                            <goal>create-repository</goal>
+                        </goals>
+                        <configuration>
+                            <repositoryLayout>flat</repositoryLayout>
+                        </configuration>
+                    </execution>
+                </executions>
+            </plugin>
             <plugin>
                 <groupId>com.googlecode.fmpp-maven-plugin</groupId>
                 <artifactId>fmpp-maven-plugin</artifactId>

http://git-wip-us.apache.org/repos/asf/storm/blob/e461dc99/storm-dist/binary/pom.xml
----------------------------------------------------------------------
diff --git a/storm-dist/binary/pom.xml b/storm-dist/binary/pom.xml
index 7504f43..dd88a87 100644
--- a/storm-dist/binary/pom.xml
+++ b/storm-dist/binary/pom.xml
@@ -38,16 +38,6 @@
         </dependency>
         <dependency>
             <groupId>org.apache.storm</groupId>
-            <artifactId>storm-sql-core</artifactId>
-            <version>${project.version}</version>
-        </dependency>
-        <dependency>
-            <groupId>org.apache.storm</groupId>
-            <artifactId>storm-sql-runtime</artifactId>
-            <version>${project.version}</version>
-        </dependency>
-        <dependency>
-            <groupId>org.apache.storm</groupId>
             <artifactId>storm-rename-hack</artifactId>
             <version>${project.version}</version>
         </dependency>

http://git-wip-us.apache.org/repos/asf/storm/blob/e461dc99/storm-dist/binary/src/main/assembly/binary.xml
----------------------------------------------------------------------
diff --git a/storm-dist/binary/src/main/assembly/binary.xml b/storm-dist/binary/src/main/assembly/binary.xml
index 9332283..7f0da6f 100644
--- a/storm-dist/binary/src/main/assembly/binary.xml
+++ b/storm-dist/binary/src/main/assembly/binary.xml
@@ -254,10 +254,10 @@
             </includes>
         </fileSet>
         <fileSet>
-            <directory>${project.basedir}/../../external/sql/storm-sql-core/target</directory>
+            <directory>${project.basedir}/../../external/sql/storm-sql-core/target/appassembler/repo</directory>
             <outputDirectory>external/sql/storm-sql-core</outputDirectory>
             <includes>
-                <include>storm*jar</include>
+                <include>*jar</include>
             </includes>
         </fileSet>
         <fileSet>


[3/3] storm git commit: Added STORM-1625 to Changelog

Posted by bo...@apache.org.
Added STORM-1625 to Changelog


Project: http://git-wip-us.apache.org/repos/asf/storm/repo
Commit: http://git-wip-us.apache.org/repos/asf/storm/commit/d3182c46
Tree: http://git-wip-us.apache.org/repos/asf/storm/tree/d3182c46
Diff: http://git-wip-us.apache.org/repos/asf/storm/diff/d3182c46

Branch: refs/heads/master
Commit: d3182c46c947378185ff7331a5c43cfa96471285
Parents: 5cd9c56
Author: Robert (Bobby) Evans <ev...@yahoo-inc.com>
Authored: Thu Mar 24 15:36:40 2016 -0500
Committer: Robert (Bobby) Evans <ev...@yahoo-inc.com>
Committed: Thu Mar 24 15:36:40 2016 -0500

----------------------------------------------------------------------
 CHANGELOG.md | 1 +
 1 file changed, 1 insertion(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/storm/blob/d3182c46/CHANGELOG.md
----------------------------------------------------------------------
diff --git a/CHANGELOG.md b/CHANGELOG.md
index bec17d2..9f077d8 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -65,6 +65,7 @@
  * STORM-1521: When using Kerberos login from keytab with multiple bolts/executors ticket is not renewed in hbase bolt.
 
 ## 1.0.0
+ * STORM-1625: Move storm-sql dependencies out of lib folder
  * STORM-1556: nimbus.clj/wait-for-desired-code-replication wrong reset for current-replication-count-jar in local mode
  * STORM-1636: Supervisor shutdown with worker id pass in being nil
  * STORM-1602: Blobstore UTs are failed on Windows


[2/3] storm git commit: Merge branch 'storm-sql' of https://github.com/abhishekagarwal87/storm into STORM-1625

Posted by bo...@apache.org.
Merge branch 'storm-sql' of https://github.com/abhishekagarwal87/storm into STORM-1625

STORM-1625: Move storm-sql dependencies out of lib folder


Project: http://git-wip-us.apache.org/repos/asf/storm/repo
Commit: http://git-wip-us.apache.org/repos/asf/storm/commit/5cd9c563
Tree: http://git-wip-us.apache.org/repos/asf/storm/tree/5cd9c563
Diff: http://git-wip-us.apache.org/repos/asf/storm/diff/5cd9c563

Branch: refs/heads/master
Commit: 5cd9c56328fec6c9caeb731d0ccb0420dd5de992
Parents: 73f6b5c e461dc9
Author: Robert (Bobby) Evans <ev...@yahoo-inc.com>
Authored: Thu Mar 24 14:26:53 2016 -0500
Committer: Robert (Bobby) Evans <ev...@yahoo-inc.com>
Committed: Thu Mar 24 14:26:53 2016 -0500

----------------------------------------------------------------------
 bin/storm.py                                   |  5 ++++-
 external/sql/storm-sql-core/pom.xml            | 18 ++++++++++++++++++
 storm-dist/binary/pom.xml                      | 10 ----------
 storm-dist/binary/src/main/assembly/binary.xml |  4 ++--
 4 files changed, 24 insertions(+), 13 deletions(-)
----------------------------------------------------------------------