You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by "apache-mynewt-bot (via GitHub)" <gi...@apache.org> on 2023/01/27 09:41:23 UTC

[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2932: ci: Add style check

apache-mynewt-bot commented on PR #2932:
URL: https://github.com/apache/mynewt-core/pull/2932#issuecomment-1406256299

   
   <!-- style-bot -->
   
   ## Style check summary
   
   ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
   
   
   #### kernel/os/src/os_callout.c
   <details>
   
   ```diff
   @@ -65,19 +66,18 @@
    }
    
    int
   -os_callout_reset(struct os_callout *c, os_time_t   ticks)
   +os_callout_reset(struct os_callout *c, os_time_t ticks)
    {
        struct os_callout *entry;
        os_sr_t sr;
   -    int  ret;
   +    int ret;
    
        /* Ensure this callout has been initialized. */
        assert(c->c_evq != NULL);
    
   -	os_trace_api_u32x2(OS_TRACE_ID_CALLOUT_RESET, (uint32_t)c, (uint32_t)ticks);
   -
   -    if (ticks > INT32_MAX)
   -    {
   +    os_trace_api_u32x2(OS_TRACE_ID_CALLOUT_RESET, (uint32_t)c, (uint32_t)ticks);
   +
   +    if (ticks > INT32_MAX) {
            ret = OS_EINVAL;
            goto err;
        }
   ```
   
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org