You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/05/05 14:03:19 UTC
[GitHub] [arrow-datafusion] Jimexist opened a new pull request #271: fix 265, log should be log10, and add ln
Jimexist opened a new pull request #271:
URL: https://github.com/apache/arrow-datafusion/pull/271
# Which issue does this PR close?
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
Closes #.
# Rationale for this change
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
# What changes are included in this PR?
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
# Are there any user-facing changes?
If there are user-facing changes then we may require documentation to be updated before approving the PR.
If there are any breaking changes to public APIs, please add the `breaking change` label.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] Jimexist commented on a change in pull request #271: [request for feedback] [breaking change] fix 265, log should be log10, and add ln
Posted by GitBox <gi...@apache.org>.
Jimexist commented on a change in pull request #271:
URL: https://github.com/apache/arrow-datafusion/pull/271#discussion_r627092828
##########
File path: datafusion/src/logical_plan/expr.rs
##########
@@ -1086,9 +1086,9 @@ unary_scalar_expr!(Trunc, trunc);
unary_scalar_expr!(Abs, abs);
unary_scalar_expr!(Signum, signum);
unary_scalar_expr!(Exp, exp);
-unary_scalar_expr!(Log, ln);
Review comment:
i guess it's kept at the https://github.com/apache/arrow-datafusion/pull/271/files#diff-97178da6c90bfcb5e3dc80f06248ac1aebdec5a0e0e1d8ea235e2f571b5badf8R227 level, not here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] Jimexist commented on pull request #271: [breaking change] fix 265, log should be log10, and add ln
Posted by GitBox <gi...@apache.org>.
Jimexist commented on pull request #271:
URL: https://github.com/apache/arrow-datafusion/pull/271#issuecomment-833516005
I've added a test suite to make it future proof: https://github.com/apache/arrow-datafusion/pull/275
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #271: [breaking change] fix 265, log should be log10, and add ln
Posted by GitBox <gi...@apache.org>.
alamb merged pull request #271:
URL: https://github.com/apache/arrow-datafusion/pull/271
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] Jimexist edited a comment on pull request #271: [breaking change] fix 265, log should be log10, and add ln
Posted by GitBox <gi...@apache.org>.
Jimexist edited a comment on pull request #271:
URL: https://github.com/apache/arrow-datafusion/pull/271#issuecomment-833516005
@alamb I've added a test suite to make it future proof: https://github.com/apache/arrow-datafusion/pull/275
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] Jimexist commented on a change in pull request #271: [request for feedback] [breaking change] fix 265, log should be log10, and add ln
Posted by GitBox <gi...@apache.org>.
Jimexist commented on a change in pull request #271:
URL: https://github.com/apache/arrow-datafusion/pull/271#discussion_r627092916
##########
File path: datafusion/src/logical_plan/expr.rs
##########
@@ -1086,9 +1086,9 @@ unary_scalar_expr!(Trunc, trunc);
unary_scalar_expr!(Abs, abs);
unary_scalar_expr!(Signum, signum);
unary_scalar_expr!(Exp, exp);
-unary_scalar_expr!(Log, ln);
Review comment:
here the macro defs shall not allow dups
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on a change in pull request #271: [request for feedback] [breaking change] fix 265, log should be log10, and add ln
Posted by GitBox <gi...@apache.org>.
alamb commented on a change in pull request #271:
URL: https://github.com/apache/arrow-datafusion/pull/271#discussion_r626673370
##########
File path: datafusion/src/logical_plan/expr.rs
##########
@@ -1086,9 +1086,9 @@ unary_scalar_expr!(Trunc, trunc);
unary_scalar_expr!(Abs, abs);
unary_scalar_expr!(Signum, signum);
unary_scalar_expr!(Exp, exp);
-unary_scalar_expr!(Log, ln);
Review comment:
perhaps we should keep a `log` entry / alias to `log10` for postgres compatibility?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] Jimexist commented on a change in pull request #271: [breaking change] fix 265, log should be log10, and add ln
Posted by GitBox <gi...@apache.org>.
Jimexist commented on a change in pull request #271:
URL: https://github.com/apache/arrow-datafusion/pull/271#discussion_r627410396
##########
File path: datafusion/src/logical_plan/expr.rs
##########
@@ -1086,9 +1086,9 @@ unary_scalar_expr!(Trunc, trunc);
unary_scalar_expr!(Abs, abs);
unary_scalar_expr!(Signum, signum);
unary_scalar_expr!(Exp, exp);
-unary_scalar_expr!(Log, ln);
Review comment:
see https://github.com/apache/arrow-datafusion/pull/275
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] seddonm1 commented on a change in pull request #271: [request for feedback] [breaking change] fix 265, log should be log10, and add ln
Posted by GitBox <gi...@apache.org>.
seddonm1 commented on a change in pull request #271:
URL: https://github.com/apache/arrow-datafusion/pull/271#discussion_r627230868
##########
File path: datafusion/src/logical_plan/expr.rs
##########
@@ -1086,9 +1086,9 @@ unary_scalar_expr!(Trunc, trunc);
unary_scalar_expr!(Abs, abs);
unary_scalar_expr!(Signum, signum);
unary_scalar_expr!(Exp, exp);
-unary_scalar_expr!(Log, ln);
Review comment:
Definitely in favour of Postgres behaviour. 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org