You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/03/11 16:28:00 UTC

[GitHub] [rocketmq-mqtt] ferrirW commented on issue #19: Confusing why append '/' to the end of topic name?

ferrirW commented on issue #19:
URL: https://github.com/apache/rocketmq-mqtt/issues/19#issuecomment-1065275572


   ok, thanks for answering.
   
   And found some code can be optimized:
   
   1. ADDFLAG & JINFLAG should be replaced with PLUS_SIGN & NUMBER_SIGN refer to unicode
   
   2. Some redundant containsKey before putIfAbsent()
   
   3. buildIntanceName -> buildInstanceName
   
   4.  TopicUtils.isMatch("t/t1/t2/", "t/#/t2/") should be false but return true now.(I know some client will do this check like poho, however, it is better for the server to do a validation as well)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org