[jira] [Commented] (OAK-4447) RepositorySidegrade: oak-segment to oak-segment-tar migrate without external datastore

["Tomek Rękawek (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OAK-4447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15322468#comment-15322468 ] 

Tomek Rękawek commented on OAK-4447:
------------------------------------

Thanks for taking care of this. A few suggestions:

* The {{src-}} prefix is used to specify the source blob store. In this case we are using the empty blob store both as a source and as a destination, so maybe {{--missingblobstore}} would be a better choice?
* It won't work for all possible combinations of node stores. For example, when migrating Segment -> Mongo, the process tries to create a blob and fails,
* It won't work for the FileBlobStore, as it tries to save the blob length in its ID and we don't have access to this information. FileBlobStore is not very popular anyway, so it's not a show-breaker.

I extended the patch with a test containing a list of working cases. Maybe we should reject the option if an unsupported combination of node stores is used?

> RepositorySidegrade: oak-segment to oak-segment-tar migrate without external datastore
> --------------------------------------------------------------------------------------
>
>                 Key: OAK-4447
>                 URL: https://issues.apache.org/jira/browse/OAK-4447
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: segment-tar, upgrade
>            Reporter: Alex Parvulescu
>         Attachments: OAK-4447-with-test.patch, upgrade-nods.patch
>
>
> I'd like to submit a patch for being able to run the sidegrade from oak-segment to oak-segment-tar without the need to have the external datastore connected.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)