You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/05/31 11:43:10 UTC

[GitHub] [spark] HyukjinKwon commented on a change in pull request #24753: [MINOR] Fix typo: isSplitable -> isSplittable

HyukjinKwon commented on a change in pull request #24753: [MINOR] Fix typo: isSplitable -> isSplittable
URL: https://github.com/apache/spark/pull/24753#discussion_r289356667
 
 

 ##########
 File path: external/avro/src/main/scala/org/apache/spark/sql/avro/AvroFileFormat.scala
 ##########
 @@ -130,7 +130,7 @@ private[avro] class AvroFileFormat extends FileFormat
 
   override def toString(): String = "Avro"
 
-  override def isSplitable(
+  override def isSplittable(
 
 Review comment:
   haha. you know what? I believe this was from Hadoop (https://github.com/apache/hadoop/search?q=IsSplitable&unscoped_q=IsSplitable)
   
   and although it's meant to be private, `FileFormat` one is pretty used here and there. Strictly we don't need to but might be good to keep the compatibility there. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org