You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Attila Bukor (Code Review)" <ge...@cloudera.org> on 2022/05/02 16:46:43 UTC
[kudu-CR] Update RELEASING doc
Hello Alexey Serbin, Andrew Wong,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/18466
to review the following change.
Change subject: Update RELEASING doc
......................................................................
Update RELEASING doc
Our releasing docs were a bit outdated, missing some things we do for a
release. I updated it based on my experience with the 1.16.0 release,
and also added some tips.
Change-Id: Ia33a44a2a1f526769be195796c3456fb47269863
---
M RELEASING.adoc
1 file changed, 64 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/66/18466/1
--
To view, visit http://gerrit.cloudera.org:8080/18466
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia33a44a2a1f526769be195796c3456fb47269863
Gerrit-Change-Number: 18466
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
[kudu-CR] Update RELEASING doc
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18466 )
Change subject: Update RELEASING doc
......................................................................
Patch Set 1:
(7 comments)
http://gerrit.cloudera.org:8080/#/c/18466/1/RELEASING.adoc
File RELEASING.adoc:
http://gerrit.cloudera.org:8080/#/c/18466/1/RELEASING.adoc@43
PS1, Line 43: _compile_the_release_notes
Just curious: is this automatically-generated anchor it's necessary to add one?
http://gerrit.cloudera.org:8080/#/c/18466/1/RELEASING.adoc@129
PS1, Line 129: git shortlog -sn $PREV..HEAD | wc -l
Is this just for stats?
http://gerrit.cloudera.org:8080/#/c/18466/1/RELEASING.adoc@130
PS1, Line 130: ff5a562e..${PREV}
nit: could this be reduced just to $PREV ?
http://gerrit.cloudera.org:8080/#/c/18466/1/RELEASING.adoc@131
PS1, Line 131: ${PREV}..HEAD
nit: could this be reduced just to $PREV.. ?
http://gerrit.cloudera.org:8080/#/c/18466/1/RELEASING.adoc@136
PS1, Line 136: $PREV..HEAD
nit: maybe just
$PREV..
http://gerrit.cloudera.org:8080/#/c/18466/1/RELEASING.adoc@435
PS1, Line 435: ./docker/docker-build.py --action push --platforms linux/amd64 linux/arm64
Any preference from where to run this command?
http://gerrit.cloudera.org:8080/#/c/18466/1/RELEASING.adoc@439
PS1, Line 439: in
: link:https://issues.apache.org/jira/browse/INFRA-23166[JIRA]
nit: how about
... via Apache JIRA ticket similar to link:https://issues.apache.org/jira/browse/INFRA-23166[this one]
--
To view, visit http://gerrit.cloudera.org:8080/18466
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia33a44a2a1f526769be195796c3456fb47269863
Gerrit-Change-Number: 18466
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 02 May 2022 18:22:34 +0000
Gerrit-HasComments: Yes
[kudu-CR] Update RELEASING doc
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/18466 )
Change subject: Update RELEASING doc
......................................................................
Patch Set 3:
(7 comments)
http://gerrit.cloudera.org:8080/#/c/18466/1/RELEASING.adoc
File RELEASING.adoc:
http://gerrit.cloudera.org:8080/#/c/18466/1/RELEASING.adoc@43
PS1, Line 43: _compile_the_release_notes
> Just curious: is this automatically-generated anchor it's necessary to add
Yep, it's automatically generated based on the heading.
http://gerrit.cloudera.org:8080/#/c/18466/1/RELEASING.adoc@129
PS1, Line 129: git shortlog -sn $PREV.. | wc -l
> Is this just for stats?
yep, we add how many people contribute to each release, and the names of new contributors, these are useful for that.
http://gerrit.cloudera.org:8080/#/c/18466/1/RELEASING.adoc@130
PS1, Line 130: ${PREV} | cut -f
> nit: could this be reduced just to $PREV ?
Done, don't know why I didn't think of that.
http://gerrit.cloudera.org:8080/#/c/18466/1/RELEASING.adoc@131
PS1, Line 131: ${PREV}.. | c
> nit: could this be reduced just to $PREV.. ?
Thanks for the tip, wasn't familiar with that one :)
http://gerrit.cloudera.org:8080/#/c/18466/1/RELEASING.adoc@136
PS1, Line 136: $PREV..` to
> nit: maybe just
Done
http://gerrit.cloudera.org:8080/#/c/18466/1/RELEASING.adoc@435
PS1, Line 435: ---
> Any preference from where to run this command?
added a note about it
http://gerrit.cloudera.org:8080/#/c/18466/1/RELEASING.adoc@439
PS1, Line 439: ou need to be granted permissions by the ASF
: infra team, which you can request via an Apache JIRA ticket
> nit: how about
Done
--
To view, visit http://gerrit.cloudera.org:8080/18466
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia33a44a2a1f526769be195796c3456fb47269863
Gerrit-Change-Number: 18466
Gerrit-PatchSet: 3
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 03 May 2022 18:01:12 +0000
Gerrit-HasComments: Yes
[kudu-CR] Update RELEASING doc
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18466
to look at the new patch set (#3).
Change subject: Update RELEASING doc
......................................................................
Update RELEASING doc
Our releasing docs were a bit outdated, missing some things we do for a
release. I updated it based on my experience with the 1.16.0 release,
and also added some tips.
Change-Id: Ia33a44a2a1f526769be195796c3456fb47269863
---
M RELEASING.adoc
1 file changed, 65 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/66/18466/3
--
To view, visit http://gerrit.cloudera.org:8080/18466
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia33a44a2a1f526769be195796c3456fb47269863
Gerrit-Change-Number: 18466
Gerrit-PatchSet: 3
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] Update RELEASING doc
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18466
to look at the new patch set (#2).
Change subject: Update RELEASING doc
......................................................................
Update RELEASING doc
Our releasing docs were a bit outdated, missing some things we do for a
release. I updated it based on my experience with the 1.16.0 release,
and also added some tips.
Change-Id: Ia33a44a2a1f526769be195796c3456fb47269863
---
M RELEASING.adoc
1 file changed, 65 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/66/18466/2
--
To view, visit http://gerrit.cloudera.org:8080/18466
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia33a44a2a1f526769be195796c3456fb47269863
Gerrit-Change-Number: 18466
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] Update RELEASING doc
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18466 )
Change subject: Update RELEASING doc
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18466/1/RELEASING.adoc
File RELEASING.adoc:
http://gerrit.cloudera.org:8080/#/c/18466/1/RELEASING.adoc@43
PS1, Line 43: _compile_the_release_notes
> Yep, it's automatically generated based on the heading.
Ah, that's cool -- thanks for clarifying.
--
To view, visit http://gerrit.cloudera.org:8080/18466
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia33a44a2a1f526769be195796c3456fb47269863
Gerrit-Change-Number: 18466
Gerrit-PatchSet: 3
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 03 May 2022 18:11:46 +0000
Gerrit-HasComments: Yes
[kudu-CR] Update RELEASING doc
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18466 )
Change subject: Update RELEASING doc
......................................................................
Update RELEASING doc
Our releasing docs were a bit outdated, missing some things we do for a
release. I updated it based on my experience with the 1.16.0 release,
and also added some tips.
Change-Id: Ia33a44a2a1f526769be195796c3456fb47269863
Reviewed-on: http://gerrit.cloudera.org:8080/18466
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <al...@apache.org>
---
M RELEASING.adoc
1 file changed, 65 insertions(+), 7 deletions(-)
Approvals:
Kudu Jenkins: Verified
Alexey Serbin: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/18466
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia33a44a2a1f526769be195796c3456fb47269863
Gerrit-Change-Number: 18466
Gerrit-PatchSet: 4
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)