You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "HappenLee (via GitHub)" <gi...@apache.org> on 2026/10/02 09:22:08 UTC
Re: [PR] [improvement](be) Prune exact scan keys by tablet bucket [doris]
HappenLee commented on PR #68553:
URL: https://github.com/apache/doris/pull/68553#issuecomment-5949089649
Fixed the BE UT fixture crash in e9165161a6d.
`OlapScanOperatorTsoPruningTest` now sizes `_tablets` to match `_scan_ranges`, as normal scanner preparation does. The tablet pointers remain null, so both empty-source tests still verify that TSO pruning reaches EOS without accessing a tablet or creating a scanner. Existing assertions are unchanged.
Validation:
- Passed clang-format 16.0.6, `git diff --check`, and build hygiene.
- Attempted ASAN `run-be-ut.sh -j 48` with `OlapScanOperatorTsoPruningTest.*:OlapScanOperatorBinlogPushDownTest.*:ScannerLateArrivalRfTest.*:ScanKeyBucketPrunerTest.*`. Local compilation stopped before running tests because the installed AWS SDK lacks `aws/core/auth/GeneralHTTPCredentialsProvider.h`, required by unchanged `common/cpp/aws_common.cpp`.
- The repository clang-tidy check returned nonzero for the existing unmatched `NOLINTEND` at `be/src/core/types.h:576`; no emitted diagnostic points to the added lines. This is not a clean static-analysis pass.
run beut
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org