You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by aledsage <gi...@git.apache.org> on 2014/10/21 17:31:34 UTC
[GitHub] incubator-brooklyn pull request: Fix MariaDB (bump version to 5.5....
GitHub user aledsage opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/262
Fix MariaDB (bump version to 5.5.40 from 5.5.33a)
- fix download URLs
- uploaded artifacts to http://developers.cloudsoftcorp.com/brooklyn/repository/MariaDbNode/5.5.40, so will not break next time mirror removes this version
- live-test stops iptables
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aledsage/incubator-brooklyn fix/MariaDB-version
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/262.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #262
----
commit eda3ae8f332cb7dbb55d6c189b64290fba147f97
Author: Aled Sage <al...@gmail.com>
Date: 2014-10-21T14:07:01Z
Fix MariaDB (bump version to 5.5.40 from 5.5.33a)
- fix download URLs
- upload to http://developers.cloudsoftcorp.com/brooklyn/repository/MariaDbNode/5.5.40
- live-test stops iptables
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Fix MariaDB (bump version to 5.5....
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/262#issuecomment-60016369
good to merge once one minor bit is confirmed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Fix MariaDB (bump version to 5.5....
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/262#discussion_r19186978
--- Diff: software/database/src/main/java/brooklyn/entity/database/mariadb/MariaDbSshDriver.java ---
@@ -72,17 +74,17 @@ public String getOsTag() {
if (os == null) return "linux-i686";
if (os.isWindows() || os.isMac())
throw new UnsupportedOperationException("only support linux versions just now; OS details: " + os);
- return "linux-" + (os.is64bit() ? "x86_64" : "i686");
+ return (os.is64bit() ? "linux-x86_64" : "linux-i686");
}
public String getDownloadParentDir() {
// NOTE: cannot rely on OsDetails.isLinux() to return true for all linux flavours, so
// explicitly test for unsupported OSes, otherwise assume generic linux.
OsDetails os = getLocation().getOsDetails();
- if (os == null) return "kvm-bintar-hardy-x86";
+ if (os == null) return "bintar-linux-x86";
if (os.isWindows() || os.isMac())
throw new UnsupportedOperationException("only support linux versions just now; OS details: " + os);
- return "kvm-bintar-hardy-" + (os.is64bit() ? "amd64" : "x86");
+ return (os.is64bit() ? "bintar-linux-x86_64" : "bintar-linux-x86");
--- End diff --
quite a significant change here -- dropping `kvm` and switching `amd64` to `x86_64`. can you confirm?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---