You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/09/01 16:52:07 UTC
[GitHub] [tvm] Lunderberg opened a new issue #8903: [Tracking][Vulkan] Extending topi/unit tests to run on Vulkan
Lunderberg opened a new issue #8903:
URL: https://github.com/apache/tvm/issues/8903
### Summary
Currently, some unit tests fail when running on the Vulkan runtime. PR (TODO: edit to add the PR shortly) parametrized the tests that are currently failing, so that the vulkan target can be marked as xfail without impacting any other runtimes. The Vulkan runtime should be improved so that these unit tests can pass on vulkan as well.
### Status
| File | Test | Parameters | Status | Owner | PR |
|----------------------------|---------------------------|----------------------|--------|-------|----|
| test_topi_math.py | test_ewise | topi_name="tan" | TODO | | |
| test_topi_math.py | test_ewise | topi_name="erf" | TODO | | |
| test_topi_math.py | test_ewise | topi_name="isnan" | TODO | | |
| test_topi_math.py | test_ewise | topi_name="isfinite" | TODO | | |
| test_topi_math.py | test_ewise | topi_name="isinf" | TODO | | |
| test_topi_reduce.py | test_reduce_map | reduce_type="sum" | TODO | | |
| test_topi_reduce.py | test_reduce_map | reduce_type="any" | TODO | | |
| test_topi_reduce.py | test_reduce_map | reduce_type="all" | TODO | | |
| test_topi_vision.py | test_proposal | | TODO | | |
| test_topi_conv1d_transpose | test_conv1d_transpose_ncw | | TODO | | |
| test_softmax.py | test_softmax | dtype="float64" | TODO | | |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Lunderberg commented on issue #8903: [Tracking][Vulkan] Extending topi/unit tests to run on Vulkan
Posted by GitBox <gi...@apache.org>.
Lunderberg commented on issue #8903:
URL: https://github.com/apache/tvm/issues/8903#issuecomment-911688266
Thank you for checking, and all except the `test_conv1d_transpose_ncw` occur on AMD as well. It's the only one that is a numerical failure, while the rest of errors that occur during codegen. I'll update the table with that information.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Lunderberg commented on issue #8903: [Tracking][Vulkan] Extending topi/unit tests to run on Vulkan
Posted by GitBox <gi...@apache.org>.
Lunderberg commented on issue #8903:
URL: https://github.com/apache/tvm/issues/8903#issuecomment-914330116
Following #8947 , added the failing relay tests to the tracking issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] masahi commented on issue #8903: [Tracking][Vulkan] Extending topi/relay tests to run on Vulkan
Posted by GitBox <gi...@apache.org>.
masahi commented on issue #8903:
URL: https://github.com/apache/tvm/issues/8903#issuecomment-918105673
@Lunderberg Are these two test cases any different? One has `pytest.xfail("Known failing test for vulkan")` but not for the other.
https://github.com/apache/tvm/blob/548675fddcf9e2ad7203fc7610189d0e94e68bc6/tests/python/relay/test_op_level2.py#L199
https://github.com/apache/tvm/blob/548675fddcf9e2ad7203fc7610189d0e94e68bc6/tests/python/relay/test_op_level2.py#L360
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] masahi commented on issue #8903: [Tracking][Vulkan] Extending topi/relay tests to run on Vulkan
Posted by GitBox <gi...@apache.org>.
masahi commented on issue #8903:
URL: https://github.com/apache/tvm/issues/8903#issuecomment-919678669
@Lunderberg The last three items in `test_any.py` are not specific to vulkan (fails on cuda as well), so I think we should drop them from the list.
They don't work on gpu targets since we don't support dynamic height or width in conv2d, for example.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Lunderberg commented on issue #8903: [Tracking][Vulkan] Extending topi/relay tests to run on Vulkan
Posted by GitBox <gi...@apache.org>.
Lunderberg commented on issue #8903:
URL: https://github.com/apache/tvm/issues/8903#issuecomment-918187677
Thank you for that catch. When refactoring the tests in #8947, I added the updated version of `test_conv2d_run`, but didn't remove the original. I have https://github.com/apache/tvm/pull/8993 open to remove the redundant `test_conv2d_run`, and have double-checked that there aren't any others that snuck in.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] masahi commented on issue #8903: [Tracking][Vulkan] Extending topi/unit tests to run on Vulkan
Posted by GitBox <gi...@apache.org>.
masahi commented on issue #8903:
URL: https://github.com/apache/tvm/issues/8903#issuecomment-910826013
This result is on a NV driver, or do they also fail on AMD?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Lunderberg commented on issue #8903: [Tracking][Vulkan] Extending topi/unit tests to run on Vulkan
Posted by GitBox <gi...@apache.org>.
Lunderberg commented on issue #8903:
URL: https://github.com/apache/tvm/issues/8903#issuecomment-910477439
@mbrookhart Regarding your comments that several of the failing unit tests had run correctly on vulkan in the past, the main breaking point was in #8127, which reads the device parameters from the physical device when the target is `"vulkan -from_device=0"`. Several of the unit tests had a hard-coded target of `"vulkan"`, tried to run with the minimum vulkan capabilities, and failed at codegen because the capability requested (e.g. 64-bit float support) wasn't listed in the target. Those fixes came along for free by parametrizing the topi tests, since the default vulkan test target uses the device query.
That said, at some point I want to ensure all tests either run correctly or have an appropriate `xfail` for the minimum vulkan feature set, but that will be a different issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org