You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Sowmya Krishnan <so...@citrix.com> on 2013/07/27 14:19:31 UTC
Do we delete an account after all users are deleted?
Do we perform any cleanup of an account if all users in that account are deleted? I don't find that is the current behavior.
I was going through test_accounts.py and figured that's one of the tests. Here's the description of that test:
# Validate the following
# 1. Remove both the users from the account.
# 2. Verify account is removed
# 3. Verify all VMs associated with that account got removed
I don't think we remove an account or its resources automatically if all users are removed in that account... Wondering if this is a valid test at all.
Thanks,
Sowmya
Re: Do we delete an account after all users are deleted?
Posted by Prasanna Santhanam <ts...@apache.org>.
On Sat, Jul 27, 2013 at 01:34:25PM +0000, Sowmya Krishnan wrote:
>
>
> > -----Original Message-----
> > From: Prasanna Santhanam [mailto:tsp@apache.org]
> > Sent: Saturday, July 27, 2013 6:55 PM
> > To: dev@cloudstack.apache.org
> > Subject: Re: Do we delete an account after all users are deleted?
> >
> > On Sat, Jul 27, 2013 at 12:19:31PM +0000, Sowmya Krishnan wrote:
> > > Do we perform any cleanup of an account if all users in that account
> > > are deleted? I don't find that is the current behavior.
> > > I was going through test_accounts.py and figured that's one of the
> > > tests. Here's the description of that test:
> > >
> > > # Validate the following
> > > # 1. Remove both the users from the account.
> > > # 2. Verify account is removed
> > > # 3. Verify all VMs associated with that account got removed
> > >
> > > I don't think we remove an account or its resources automatically if
> > > all users are removed in that account... Wondering if this is a valid
> > > test at all.
> > >
> >
> > Yes the test is invalid. It had been skipped earlier with ("Open
> > Questions") in the reason. Probably something that was in a test plan but didn't
> > have clarity at the time it was written. I removed all skips in the tests so we'll
> > find those invalid ones now.
>
> Ok. This one evidently failed cleanup and surfaced here:
> https://issues.apache.org/jira/browse/CLOUDSTACK-3746
Not much info in that bug report to tell why it failed. From what I
gather, we are probably missing a few account cleanups in some of the
suites and this one is one of them.
> We have a list of "to-be-skipped" tests? Just wondering how many
> more we have.
It's in the git logs but do you want to skip them now? I'd rather weed
out the invalid ones as they fail.
03e283c4b3ed0046a47777b9dc1ad4ab948254af
8bc72ad55c76635939f463185291b0c283b57858
a4356b559cb1401c790e1aa62606c1f256e75229
--
Prasanna.,
------------------------
Powered by BigRock.com
Re: Do we delete an account after all users are deleted?
Posted by Prasanna Santhanam <ts...@apache.org>.
I've removed the invalid tests from test_accounts when I noticed we
don't have any tests for lock/disable accounts in there. Filed a bug
for the missing tests: CLOUDSTACK-3884
On Sat, Jul 27, 2013 at 03:19:52PM +0000, Sowmya Krishnan wrote:
> That's the behavior right now - we don't delete the account if users are all deleted.
> So we just need the test script to be removed/altered which is testing the other way.
>
> > -----Original Message-----
> > From: Alex Huang [mailto:Alex.Huang@citrix.com]
> > Sent: Saturday, July 27, 2013 8:38 PM
> > To: dev@cloudstack.apache.org
> > Subject: RE: Do we delete an account after all users are deleted?
> >
> > The bug is scarce on details.
> >
> > Assuming I understand what is asked correctly, this should not be done at all. A
> > deletion of an account triggers an expunge of the all resources. Suppose
> > someone made a mistake and removed all users from an account and cs
> > automatically deleted the account and automatically cleaned out the resources.
> > Not a good idea. Better to specifically delete the account.
> >
> > --Alex
> >
> > > -----Original Message-----
> > > From: Sowmya Krishnan [mailto:sowmya.krishnan@citrix.com]
> > > Sent: Saturday, July 27, 2013 6:52 AM
> > > To: dev@cloudstack.apache.org
> > > Subject: RE: Do we delete an account after all users are deleted?
> > >
> > >
> > >
> > > > -----Original Message-----
> > > > From: Sowmya Krishnan [mailto:sowmya.krishnan@citrix.com]
> > > > Sent: Saturday, July 27, 2013 7:05 PM
> > > > To: dev@cloudstack.apache.org
> > > > Subject: RE: Do we delete an account after all users are deleted?
> > > >
> > > >
> > > >
> > > > > -----Original Message-----
> > > > > From: Prasanna Santhanam [mailto:tsp@apache.org]
> > > > > Sent: Saturday, July 27, 2013 6:55 PM
> > > > > To: dev@cloudstack.apache.org
> > > > > Subject: Re: Do we delete an account after all users are deleted?
> > > > >
> > > > > On Sat, Jul 27, 2013 at 12:19:31PM +0000, Sowmya Krishnan wrote:
> > > > > > Do we perform any cleanup of an account if all users in that
> > > > > > account are deleted? I don't find that is the current behavior.
> > > > > > I was going through test_accounts.py and figured that's one of
> > > > > > the tests. Here's the description of that test:
> > > > > >
> > > > > > # Validate the following
> > > > > > # 1. Remove both the users from the account.
> > > > > > # 2. Verify account is removed
> > > > > > # 3. Verify all VMs associated with that account got
> > > > > > removed
> > > > > >
> > > > > > I don't think we remove an account or its resources
> > > > > > automatically if all users are removed in that account...
> > > > > > Wondering if this is a valid test at all.
> > > > > >
> > > > >
> > > > > Yes the test is invalid. It had been skipped earlier with ("Open
> > > > > Questions") in the reason. Probably something that was in a test
> > > > > plan but didn't have clarity at the time it was written. I removed
> > > > > all skips in the tests so we'll find those invalid ones now.
> > > >
> > > > Ok. This one evidently failed cleanup and surfaced here:
> > > > https://issues.apache.org/jira/browse/CLOUDSTACK-3746
> > >
> > > It's this one in fact:
> > > https://issues.apache.org/jira/browse/CLOUDSTACK-
> > > 3745
> > >
> > > > We have a list of "to-be-skipped" tests? Just wondering how many
> > > > more we have.
> > > >
> > > > >
> > > > > --
> > > > > Prasanna.,
> > > > >
> > > > > ------------------------
> > > > > Powered by BigRock.com
--
Prasanna.,
------------------------
Powered by BigRock.com
RE: Do we delete an account after all users are deleted?
Posted by Sowmya Krishnan <so...@citrix.com>.
That's the behavior right now - we don't delete the account if users are all deleted.
So we just need the test script to be removed/altered which is testing the other way.
> -----Original Message-----
> From: Alex Huang [mailto:Alex.Huang@citrix.com]
> Sent: Saturday, July 27, 2013 8:38 PM
> To: dev@cloudstack.apache.org
> Subject: RE: Do we delete an account after all users are deleted?
>
> The bug is scarce on details.
>
> Assuming I understand what is asked correctly, this should not be done at all. A
> deletion of an account triggers an expunge of the all resources. Suppose
> someone made a mistake and removed all users from an account and cs
> automatically deleted the account and automatically cleaned out the resources.
> Not a good idea. Better to specifically delete the account.
>
> --Alex
>
> > -----Original Message-----
> > From: Sowmya Krishnan [mailto:sowmya.krishnan@citrix.com]
> > Sent: Saturday, July 27, 2013 6:52 AM
> > To: dev@cloudstack.apache.org
> > Subject: RE: Do we delete an account after all users are deleted?
> >
> >
> >
> > > -----Original Message-----
> > > From: Sowmya Krishnan [mailto:sowmya.krishnan@citrix.com]
> > > Sent: Saturday, July 27, 2013 7:05 PM
> > > To: dev@cloudstack.apache.org
> > > Subject: RE: Do we delete an account after all users are deleted?
> > >
> > >
> > >
> > > > -----Original Message-----
> > > > From: Prasanna Santhanam [mailto:tsp@apache.org]
> > > > Sent: Saturday, July 27, 2013 6:55 PM
> > > > To: dev@cloudstack.apache.org
> > > > Subject: Re: Do we delete an account after all users are deleted?
> > > >
> > > > On Sat, Jul 27, 2013 at 12:19:31PM +0000, Sowmya Krishnan wrote:
> > > > > Do we perform any cleanup of an account if all users in that
> > > > > account are deleted? I don't find that is the current behavior.
> > > > > I was going through test_accounts.py and figured that's one of
> > > > > the tests. Here's the description of that test:
> > > > >
> > > > > # Validate the following
> > > > > # 1. Remove both the users from the account.
> > > > > # 2. Verify account is removed
> > > > > # 3. Verify all VMs associated with that account got
> > > > > removed
> > > > >
> > > > > I don't think we remove an account or its resources
> > > > > automatically if all users are removed in that account...
> > > > > Wondering if this is a valid test at all.
> > > > >
> > > >
> > > > Yes the test is invalid. It had been skipped earlier with ("Open
> > > > Questions") in the reason. Probably something that was in a test
> > > > plan but didn't have clarity at the time it was written. I removed
> > > > all skips in the tests so we'll find those invalid ones now.
> > >
> > > Ok. This one evidently failed cleanup and surfaced here:
> > > https://issues.apache.org/jira/browse/CLOUDSTACK-3746
> >
> > It's this one in fact:
> > https://issues.apache.org/jira/browse/CLOUDSTACK-
> > 3745
> >
> > > We have a list of "to-be-skipped" tests? Just wondering how many
> > > more we have.
> > >
> > > >
> > > > --
> > > > Prasanna.,
> > > >
> > > > ------------------------
> > > > Powered by BigRock.com
RE: Do we delete an account after all users are deleted?
Posted by Alex Huang <Al...@citrix.com>.
The bug is scarce on details.
Assuming I understand what is asked correctly, this should not be done at all. A deletion of an account triggers an expunge of the all resources. Suppose someone made a mistake and removed all users from an account and cs automatically deleted the account and automatically cleaned out the resources. Not a good idea. Better to specifically delete the account.
--Alex
> -----Original Message-----
> From: Sowmya Krishnan [mailto:sowmya.krishnan@citrix.com]
> Sent: Saturday, July 27, 2013 6:52 AM
> To: dev@cloudstack.apache.org
> Subject: RE: Do we delete an account after all users are deleted?
>
>
>
> > -----Original Message-----
> > From: Sowmya Krishnan [mailto:sowmya.krishnan@citrix.com]
> > Sent: Saturday, July 27, 2013 7:05 PM
> > To: dev@cloudstack.apache.org
> > Subject: RE: Do we delete an account after all users are deleted?
> >
> >
> >
> > > -----Original Message-----
> > > From: Prasanna Santhanam [mailto:tsp@apache.org]
> > > Sent: Saturday, July 27, 2013 6:55 PM
> > > To: dev@cloudstack.apache.org
> > > Subject: Re: Do we delete an account after all users are deleted?
> > >
> > > On Sat, Jul 27, 2013 at 12:19:31PM +0000, Sowmya Krishnan wrote:
> > > > Do we perform any cleanup of an account if all users in that
> > > > account are deleted? I don't find that is the current behavior.
> > > > I was going through test_accounts.py and figured that's one of the
> > > > tests. Here's the description of that test:
> > > >
> > > > # Validate the following
> > > > # 1. Remove both the users from the account.
> > > > # 2. Verify account is removed
> > > > # 3. Verify all VMs associated with that account got
> > > > removed
> > > >
> > > > I don't think we remove an account or its resources automatically
> > > > if all users are removed in that account... Wondering if this is a
> > > > valid test at all.
> > > >
> > >
> > > Yes the test is invalid. It had been skipped earlier with ("Open
> > > Questions") in the reason. Probably something that was in a test
> > > plan but didn't have clarity at the time it was written. I removed
> > > all skips in the tests so we'll find those invalid ones now.
> >
> > Ok. This one evidently failed cleanup and surfaced here:
> > https://issues.apache.org/jira/browse/CLOUDSTACK-3746
>
> It's this one in fact: https://issues.apache.org/jira/browse/CLOUDSTACK-
> 3745
>
> > We have a list of "to-be-skipped" tests? Just wondering how many more
> > we have.
> >
> > >
> > > --
> > > Prasanna.,
> > >
> > > ------------------------
> > > Powered by BigRock.com
RE: Do we delete an account after all users are deleted?
Posted by Sowmya Krishnan <so...@citrix.com>.
> -----Original Message-----
> From: Sowmya Krishnan [mailto:sowmya.krishnan@citrix.com]
> Sent: Saturday, July 27, 2013 7:05 PM
> To: dev@cloudstack.apache.org
> Subject: RE: Do we delete an account after all users are deleted?
>
>
>
> > -----Original Message-----
> > From: Prasanna Santhanam [mailto:tsp@apache.org]
> > Sent: Saturday, July 27, 2013 6:55 PM
> > To: dev@cloudstack.apache.org
> > Subject: Re: Do we delete an account after all users are deleted?
> >
> > On Sat, Jul 27, 2013 at 12:19:31PM +0000, Sowmya Krishnan wrote:
> > > Do we perform any cleanup of an account if all users in that account
> > > are deleted? I don't find that is the current behavior.
> > > I was going through test_accounts.py and figured that's one of the
> > > tests. Here's the description of that test:
> > >
> > > # Validate the following
> > > # 1. Remove both the users from the account.
> > > # 2. Verify account is removed
> > > # 3. Verify all VMs associated with that account got removed
> > >
> > > I don't think we remove an account or its resources automatically if
> > > all users are removed in that account... Wondering if this is a
> > > valid test at all.
> > >
> >
> > Yes the test is invalid. It had been skipped earlier with ("Open
> > Questions") in the reason. Probably something that was in a test plan
> > but didn't have clarity at the time it was written. I removed all
> > skips in the tests so we'll find those invalid ones now.
>
> Ok. This one evidently failed cleanup and surfaced here:
> https://issues.apache.org/jira/browse/CLOUDSTACK-3746
It's this one in fact: https://issues.apache.org/jira/browse/CLOUDSTACK-3745
> We have a list of "to-be-skipped" tests? Just wondering how many more we
> have.
>
> >
> > --
> > Prasanna.,
> >
> > ------------------------
> > Powered by BigRock.com
RE: Do we delete an account after all users are deleted?
Posted by Sowmya Krishnan <so...@citrix.com>.
> -----Original Message-----
> From: Prasanna Santhanam [mailto:tsp@apache.org]
> Sent: Saturday, July 27, 2013 6:55 PM
> To: dev@cloudstack.apache.org
> Subject: Re: Do we delete an account after all users are deleted?
>
> On Sat, Jul 27, 2013 at 12:19:31PM +0000, Sowmya Krishnan wrote:
> > Do we perform any cleanup of an account if all users in that account
> > are deleted? I don't find that is the current behavior.
> > I was going through test_accounts.py and figured that's one of the
> > tests. Here's the description of that test:
> >
> > # Validate the following
> > # 1. Remove both the users from the account.
> > # 2. Verify account is removed
> > # 3. Verify all VMs associated with that account got removed
> >
> > I don't think we remove an account or its resources automatically if
> > all users are removed in that account... Wondering if this is a valid
> > test at all.
> >
>
> Yes the test is invalid. It had been skipped earlier with ("Open
> Questions") in the reason. Probably something that was in a test plan but didn't
> have clarity at the time it was written. I removed all skips in the tests so we'll
> find those invalid ones now.
Ok. This one evidently failed cleanup and surfaced here: https://issues.apache.org/jira/browse/CLOUDSTACK-3746
We have a list of "to-be-skipped" tests? Just wondering how many more we have.
>
> --
> Prasanna.,
>
> ------------------------
> Powered by BigRock.com
Re: Do we delete an account after all users are deleted?
Posted by Prasanna Santhanam <ts...@apache.org>.
On Sat, Jul 27, 2013 at 12:19:31PM +0000, Sowmya Krishnan wrote:
> Do we perform any cleanup of an account if all users in that account
> are deleted? I don't find that is the current behavior.
> I was going through test_accounts.py and figured that's one of the
> tests. Here's the description of that test:
>
> # Validate the following
> # 1. Remove both the users from the account.
> # 2. Verify account is removed
> # 3. Verify all VMs associated with that account got removed
>
> I don't think we remove an account or its resources automatically if
> all users are removed in that account... Wondering if this is a
> valid test at all.
>
Yes the test is invalid. It had been skipped earlier with ("Open
Questions") in the reason. Probably something that was in a test plan
but didn't have clarity at the time it was written. I removed all
skips in the tests so we'll find those invalid ones now.
--
Prasanna.,
------------------------
Powered by BigRock.com