You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-commits@jackrabbit.apache.org by re...@apache.org on 2017/03/13 09:39:53 UTC
svn commit: r1786646 - in /jackrabbit/oak/branches/1.4: ./
oak-core/src/test/java/org/apache/jackrabbit/oak/plugins/document/CacheConsistencyTestBase.java
Author: reschke
Date: Mon Mar 13 09:39:53 2017
New Revision: 1786646
URL: http://svn.apache.org/viewvc?rev=1786646&view=rev
Log:
OAK-4802: Basic cache consistency test on exception (ported to 1.4)
Modified:
jackrabbit/oak/branches/1.4/ (props changed)
jackrabbit/oak/branches/1.4/oak-core/src/test/java/org/apache/jackrabbit/oak/plugins/document/CacheConsistencyTestBase.java
Propchange: jackrabbit/oak/branches/1.4/
------------------------------------------------------------------------------
--- svn:mergeinfo (original)
+++ svn:mergeinfo Mon Mar 13 09:39:53 2017
@@ -1,3 +1,3 @@
/jackrabbit/oak/branches/1.0:1665962
-/jackrabbit/oak/trunk:1733615,1733875,1733913,1733929,1734230,1734254,1734279,1734941,1735052,1735081,1735109,1735141,1735267,1735405,1735484,1735549,1735564,1735588,1735622,1735638,1735919,1735983,1736176,1737309-1737310,1737334,1737349,1737998,1738004,1738136,1738138,1738207,1738234,1738252,1738775,1738795,1738833,1738950,1738957,1738963,1739712,1739760,1739867,1739894,1739959-1739960,1740114,1740116,1740250,1740333,1740349,1740360,1740625-1740626,1740774,1740837,1740879,1740971,1741016,1741032,1741339,1741343,1742077,1742117,1742125,1742363,1742520,1742888,1742916,1743097,1743172,1743343,1743674,1744265,1744292,1744589,1744670,1744672,1744959,1745038,1745127,1745197,1745336,1745368,1746086,1746117,1746342,1746345,1746408,1746634,1746696,1746981,1747198,1747200,1747341-1747342,1747380,1747387,1747406,1747492,1747512,1747654,1748505,1748553,1748722,1748870,1749275,1749350,1749424,1749443,1749464,1749475,1749645,1749662,1749815,1749872,1749875,1749899,1750052,1750076-1750077,1750287
,1750457,1750462,1750465,1750495,1750626,1750809,1750886-1750887,1751396,1751410,1751419,1751445-1751446,1751478,1751748,1751753,1751755,1751871,1752198,1752202,1752259,1752273-1752274,1752283,1752292,1752438,1752447-1752448,1752508,1752596,1752616,1752659,1752672,1753262,1753331-1753332,1753335-1753336,1753355,1753444,1754117,1754239,1755157,1755191,1756520,1756580,1757119,1757166,1758213,1758713,1759433,1759795,1759826,1760326,1760340,1760373,1760387,1760486,1760492,1760494,1760661-1760662,1760677,1761412,1761444,1761571,1761762,1761787,1761876,1762453,1762612,1762632,1762635,1763347,1763355-1763356,1763378,1763465,1763735,1764678,1764705,1764814,1764898,1765817,1765983,1766071,1766390,1766423,1766496,1766519,1766554,1766644,1767025,1767265,1767704,1768446,1768637,1769078,1770694,1770982,1771022,1771093,1771098,1771739,1771852,1771870,1771902,1772155,1772162,1772228,1772593,1772768,1773190,1774497,1775474,1775622,1775628,1775757,1778423,1778968,1779478,1780388,1780538,1780543,1781
068,1781075,1781386,1781846,1781907,1782476,1783066,1783089,1783104-1783105,1783619,1783855,1784023,1784130,1784251,1784574,1784689,1785283
+/jackrabbit/oak/trunk:1733615,1733875,1733913,1733929,1734230,1734254,1734279,1734941,1735052,1735081,1735109,1735141,1735267,1735405,1735484,1735549,1735564,1735588,1735622,1735638,1735919,1735983,1736176,1737309-1737310,1737334,1737349,1737998,1738004,1738136,1738138,1738207,1738234,1738252,1738775,1738795,1738833,1738950,1738957,1738963,1739712,1739760,1739867,1739894,1739959-1739960,1740114,1740116,1740250,1740333,1740349,1740360,1740625-1740626,1740774,1740837,1740879,1740971,1741016,1741032,1741339,1741343,1742077,1742117,1742125,1742363,1742520,1742888,1742916,1743097,1743172,1743343,1743674,1744265,1744292,1744589,1744670,1744672,1744959,1745038,1745127,1745197,1745336,1745368,1746086,1746117,1746342,1746345,1746408,1746634,1746696,1746981,1747198,1747200,1747341-1747342,1747380,1747387,1747406,1747492,1747512,1747654,1748505,1748553,1748722,1748870,1749275,1749350,1749424,1749443,1749464,1749475,1749645,1749662,1749815,1749872,1749875,1749899,1750052,1750076-1750077,1750287
,1750457,1750462,1750465,1750495,1750626,1750809,1750886-1750887,1751396,1751410,1751419,1751445-1751446,1751478,1751748,1751753,1751755,1751871,1752198,1752202,1752259,1752273-1752274,1752283,1752292,1752438,1752447-1752448,1752508,1752596,1752616,1752659,1752672,1753262,1753331-1753332,1753335-1753336,1753355,1753444,1754117,1754239,1755157,1755191,1756520,1756580,1757119,1757166,1758213,1758713,1759433,1759795,1759826,1760326,1760340,1760373,1760387,1760486,1760492,1760494,1760661-1760662,1760677,1760701,1761412,1761444,1761571,1761762,1761787,1761876,1762453,1762612,1762632,1762635,1763347,1763355-1763356,1763378,1763465,1763735,1764678,1764705,1764814,1764898,1765817,1765983,1766071,1766390,1766423,1766496,1766519,1766554,1766644,1767025,1767265,1767704,1768446,1768637,1769078,1770694,1770982,1771022,1771093,1771098,1771739,1771852,1771870,1771902,1772155,1772162,1772228,1772593,1772768,1773190,1774497,1775474,1775622,1775628,1775757,1778423,1778968,1779478,1780388,1780538,1780
543,1781068,1781075,1781386,1781846,1781907,1782476,1783066,1783089,1783104-1783105,1783619,1783855,1784023,1784130,1784251,1784574,1784689,1785283
/jackrabbit/trunk:1345480
Modified: jackrabbit/oak/branches/1.4/oak-core/src/test/java/org/apache/jackrabbit/oak/plugins/document/CacheConsistencyTestBase.java
URL: http://svn.apache.org/viewvc/jackrabbit/oak/branches/1.4/oak-core/src/test/java/org/apache/jackrabbit/oak/plugins/document/CacheConsistencyTestBase.java?rev=1786646&r1=1786645&r2=1786646&view=diff
==============================================================================
--- jackrabbit/oak/branches/1.4/oak-core/src/test/java/org/apache/jackrabbit/oak/plugins/document/CacheConsistencyTestBase.java (original)
+++ jackrabbit/oak/branches/1.4/oak-core/src/test/java/org/apache/jackrabbit/oak/plugins/document/CacheConsistencyTestBase.java Mon Mar 13 09:39:53 2017
@@ -21,6 +21,8 @@ import java.util.Collections;
import java.util.List;
import java.util.UUID;
+import com.google.common.collect.Lists;
+
import org.junit.After;
import org.junit.Before;
import org.junit.Test;
@@ -57,33 +59,47 @@ public abstract class CacheConsistencyTe
@Test
public void testExceptionInvalidatesCache() {
- String id = this.getClass().getName() + ".testExceptionInvalidatesCache";
- UpdateOp up = new UpdateOp(id, true);
- up.set("_id", id);
- up.set("_test", "oldvalue");
- ds.create(Collection.NODES, Collections.singletonList(up));
- removeMe.add(id);
+ String id1 = this.getClass().getName() + ".testExceptionInvalidatesCache1";
+ UpdateOp up1 = new UpdateOp(id1, true);
+ up1.set("_id", id1);
+ up1.set("_test", "oldvalue");
+ String id2 = this.getClass().getName() + ".testExceptionInvalidatesCache2";
+ UpdateOp up2 = new UpdateOp(id2, true);
+ up2.set("_id", id2);
+ up2.set("_test", "oldvalue");
+ String id3 = this.getClass().getName() + ".testExceptionInvalidatesCache3";
+ UpdateOp up3 = new UpdateOp(id3, true);
+ up3.set("_id", id3);
+ up3.set("_test", "oldvalue");
+ ds.create(Collection.NODES, Lists.newArrayList(up1, up2, up3));
+ removeMe.add(id1);
+ removeMe.add(id2);
+ removeMe.add(id3);
// make sure cache is populated
- NodeDocument olddoc = ds.find(Collection.NODES, id, 1000);
+ NodeDocument olddoc = ds.find(Collection.NODES, id1, 1000);
+ assertEquals("oldvalue", olddoc.get("_test"));
+ olddoc = ds.find(Collection.NODES, id2, 1000);
+ assertEquals("oldvalue", olddoc.get("_test"));
+ olddoc = ds.find(Collection.NODES, id3, 1000);
assertEquals("oldvalue", olddoc.get("_test"));
// findAndUpdate
try {
// make sure cache is populated
- olddoc = ds.find(Collection.NODES, id);
+ olddoc = ds.find(Collection.NODES, id1);
String random = UUID.randomUUID().toString();
setTemporaryUpdateException(random);
try {
- up = new UpdateOp(id, false);
- up.set("_id", id);
- up.set("_test", random);
- ds.findAndUpdate(Collection.NODES, up);
+ up1 = new UpdateOp(id1, false);
+ up1.set("_id", id1);
+ up1.set("_test", random);
+ ds.findAndUpdate(Collection.NODES, up1);
fail("should have failed with DocumentStoreException");
} catch (DocumentStoreException ex) {
assertEquals("should fail with enforced exception", ex.getCause().getMessage(), random);
// make sure cache was invalidated
- NodeDocument newdoc = ds.find(Collection.NODES, id, 1000);
+ NodeDocument newdoc = ds.find(Collection.NODES, id1, 1000);
assertNotNull(newdoc);
assertEquals(random, newdoc.get("_test"));
}
@@ -94,20 +110,20 @@ public abstract class CacheConsistencyTe
// update
try {
// make sure cache is populated
- olddoc = ds.find(Collection.NODES, id);
+ olddoc = ds.find(Collection.NODES, id1);
String random = UUID.randomUUID().toString();
setTemporaryUpdateException(random);
try {
- up = new UpdateOp(id, false);
- up.set("_id", id);
- up.set("_test", random);
- ds.update(Collection.NODES, Collections.singletonList(id), up);
+ up1 = new UpdateOp(id1, false);
+ up1.set("_id", id1);
+ up1.set("_test", random);
+ ds.update(Collection.NODES, Collections.singletonList(id1), up1);
fail("should have failed with DocumentStoreException");
} catch (DocumentStoreException ex) {
assertEquals("should fail with enforced exception", ex.getCause().getMessage(), random);
// make sure cache was invalidated
- NodeDocument newdoc = ds.find(Collection.NODES, id, 1000);
+ NodeDocument newdoc = ds.find(Collection.NODES, id1, 1000);
assertNotNull(newdoc);
assertEquals(random, newdoc.get("_test"));
}
@@ -118,20 +134,62 @@ public abstract class CacheConsistencyTe
// createOrUpdate
try {
// make sure cache is populated
- olddoc = ds.find(Collection.NODES, id);
+ olddoc = ds.find(Collection.NODES, id1);
String random = UUID.randomUUID().toString();
setTemporaryUpdateException(random);
try {
- up = new UpdateOp(id, false);
- up.set("_id", id);
- up.set("_test", random);
- ds.createOrUpdate(Collection.NODES, up);
+ up1 = new UpdateOp(id1, false);
+ up1.set("_id", id1);
+ up1.set("_test", random);
+ ds.createOrUpdate(Collection.NODES, up1);
fail("should have failed with DocumentStoreException");
} catch (DocumentStoreException ex) {
assertEquals("should fail with enforced exception", ex.getCause().getMessage(), random);
// make sure cache was invalidated
- NodeDocument newdoc = ds.find(Collection.NODES, id, 1000);
+ NodeDocument newdoc = ds.find(Collection.NODES, id1, 1000);
+ assertNotNull(newdoc);
+ assertEquals(random, newdoc.get("_test"));
+ }
+ } finally {
+ setTemporaryUpdateException(null);
+ }
+
+ // createOrUpdate multiple
+ try {
+ // make sure cache is populated
+ olddoc = ds.find(Collection.NODES, id1);
+ assertNotNull(olddoc);
+ olddoc = ds.find(Collection.NODES, id2);
+ assertNotNull(olddoc);
+ olddoc = ds.find(Collection.NODES, id3);
+ assertNotNull(olddoc);
+
+ String random = UUID.randomUUID().toString();
+ setTemporaryUpdateException(random);
+ try {
+ up1 = new UpdateOp(id1, false);
+ up1.set("_id", id1);
+ up1.set("_test", random);
+ up2 = new UpdateOp(id2, false);
+ up2.set("_id", id2);
+ up2.set("_test", random);
+ up3 = new UpdateOp(id3, false);
+ up3.set("_id", id3);
+ up3.set("_test", random);
+
+ ds.createOrUpdate(Collection.NODES, Lists.newArrayList(up1, up2, up3));
+ fail("should have failed with DocumentStoreException");
+ } catch (DocumentStoreException ex) {
+ assertEquals("should fail with enforced exception", ex.getCause().getMessage(), random);
+ // make sure cache was invalidated
+ NodeDocument newdoc = ds.find(Collection.NODES, id1, 1000);
+ assertNotNull(newdoc);
+ assertEquals(random, newdoc.get("_test"));
+ newdoc = ds.find(Collection.NODES, id2, 1000);
+ assertNotNull(newdoc);
+ assertEquals(random, newdoc.get("_test"));
+ newdoc = ds.find(Collection.NODES, id3, 1000);
assertNotNull(newdoc);
assertEquals(random, newdoc.get("_test"));
}
@@ -144,12 +202,12 @@ public abstract class CacheConsistencyTe
String random = UUID.randomUUID().toString();
setTemporaryUpdateException(random);
try {
- ds.remove(Collection.NODES, id);
+ ds.remove(Collection.NODES, id1);
fail("should have failed with DocumentStoreException");
} catch (DocumentStoreException ex) {
assertEquals("should fail with enforced exception", ex.getCause().getMessage(), random);
// make sure cache was invalidated
- NodeDocument newdoc = ds.find(Collection.NODES, id, 1000);
+ NodeDocument newdoc = ds.find(Collection.NODES, id1, 1000);
assertNull(newdoc);
}
} finally {