You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/02/04 19:32:51 UTC
[GitHub] [druid] gianm commented on issue #9308: Add MemoryOpenHashTable,
a table similar to ByteBufferHashTable.
gianm commented on issue #9308: Add MemoryOpenHashTable, a table similar to ByteBufferHashTable.
URL: https://github.com/apache/druid/pull/9308#issuecomment-582077195
> 6 for Result of multiplication cast to wider type
I think the LGTM alerts are false positives. It looks like it's flagging a potential overflow in calls like `2 * Integer.BYTES` before being passed to `memory.getByte(position + 2 * Integer.BYTES)`. But it won't overflow because `Integer.BYTES` is a small constant.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org