You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/09/09 08:19:41 UTC
[GitHub] [camel] erard22 opened a new pull request #4177: CAMEL-15486 Move skipping of context start to method `beforeTestClass`
erard22 opened a new pull request #4177:
URL: https://github.com/apache/camel/pull/4177
CAMEL-15486 Move skipping of context start to method `beforeTestClass` to have the settings earlier in the test lifecycle.
Some other libraries (for example: `spring-cloud-contract-wiremock` ) are starting up the context already in this phase of the test lifecycle and prevent camel of setting up the mocking of endpoints.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #4177: CAMEL-15486 Move skipping of context start to method `beforeTestClass`
Posted by GitBox <gi...@apache.org>.
davsclaus commented on pull request #4177:
URL: https://github.com/apache/camel/pull/4177#issuecomment-689525998
Have you tested this with your use-case, and if possible test with camel itself such as camel-spring, and the camel-spring-boot project.
I wonder if the prepareTestIntance is invoked only once per test class, or would it be invoked multiple times? If only once then this PR seems more safe
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] erard22 commented on pull request #4177: CAMEL-15486 Move skipping of context start to method `beforeTestClass`
Posted by GitBox <gi...@apache.org>.
erard22 commented on pull request #4177:
URL: https://github.com/apache/camel/pull/4177#issuecomment-690017022
You are right. It worked with my Mickey Mouse example but not with multiple tests. The 'startup prevention' is needed in both cases. At the very first beginning to prevent other extension from starting the context and in the test preparation for every single test case as the flags are reverted afterwards.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus merged pull request #4177: CAMEL-15486 Move skipping of context start to method `beforeTestClass`
Posted by GitBox <gi...@apache.org>.
davsclaus merged pull request #4177:
URL: https://github.com/apache/camel/pull/4177
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org