You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/08/14 09:44:31 UTC
[GitHub] [incubator-nuttx-apps] no1wudi opened a new pull request #365: interpreters/duktape: Add console/print/alart support
no1wudi opened a new pull request #365:
URL: https://github.com/apache/incubator-nuttx-apps/pull/365
## Summary
Minor change for makefile, add duktape's builtin console/print/alart module support.
## Impact
Duktape interpreter
## Testing
Tested on stm32f746g-disco & sim.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] Ouss4 commented on a change in pull request #365: interpreters/duktape: Add console/print/alart support
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on a change in pull request #365:
URL: https://github.com/apache/incubator-nuttx-apps/pull/365#discussion_r470615645
##########
File path: interpreters/duktape/Makefile
##########
@@ -27,6 +27,8 @@ DUKTAPE_URL_BASE = https://github.com/svaarala/duktape/releases/download/
DUKTAPE_URL = $(DUKTAPE_URL_BASE)v$(DUKTAPE_VERSION)/$(DUKTAPE_TARBALL)
CSRCS = $(DUKTAPE_UNPACK)/src-noline/duktape.c
+CSRCS += $(DUKTAPE_UNPACK)/extras/console/duk_console.c
+CSRCS += $(DUKTAPE_UNPACK)/extras/print-alert/duk_print_alert.c
Review comment:
I asked a similar question in a merged PR, don't you need to extend clean to delete the object files generated?
With how the makefile is setup the objects are generated in `$(DUKTAPE_UNPACK)/extras/console/` for the `duk_console.c` as an example, right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] Ouss4 merged pull request #365: interpreters/duktape: Add console/print/alart support
Posted by GitBox <gi...@apache.org>.
Ouss4 merged pull request #365:
URL: https://github.com/apache/incubator-nuttx-apps/pull/365
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] no1wudi commented on a change in pull request #365: interpreters/duktape: Add console/print/alart support
Posted by GitBox <gi...@apache.org>.
no1wudi commented on a change in pull request #365:
URL: https://github.com/apache/incubator-nuttx-apps/pull/365#discussion_r470623008
##########
File path: interpreters/duktape/Makefile
##########
@@ -27,6 +27,8 @@ DUKTAPE_URL_BASE = https://github.com/svaarala/duktape/releases/download/
DUKTAPE_URL = $(DUKTAPE_URL_BASE)v$(DUKTAPE_VERSION)/$(DUKTAPE_TARBALL)
CSRCS = $(DUKTAPE_UNPACK)/src-noline/duktape.c
+CSRCS += $(DUKTAPE_UNPACK)/extras/console/duk_console.c
+CSRCS += $(DUKTAPE_UNPACK)/extras/print-alert/duk_print_alert.c
Review comment:
I got it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org