You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Daniel Gergely <dg...@hortonworks.com> on 2016/04/01 15:20:32 UTC
Review Request 45587: Upgrade to trunk fails due AuditLogger
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45587/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez, Oliver Szabo, and Sebastian Toader.
Bugs: AMBARI-15669
https://issues.apache.org/jira/browse/AMBARI-15669
Repository: ambari
Description
-------
AuditLoggerModule was missing when injector is created for SchemaUpgradeHelper. AuditLoggerModule is now added to the injector.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java 89e920d
Diff: https://reviews.apache.org/r/45587/diff/
Testing
-------
I did an upgrade from 2.2.2 to trunk to verify the fix.
Thanks,
Daniel Gergely
Re: Review Request 45587: Upgrade to trunk fails due AuditLogger
Posted by Sebastian Toader <st...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45587/#review126578
-----------------------------------------------------------
Ship it!
Ship It!
- Sebastian Toader
On April 1, 2016, 3:20 p.m., Daniel Gergely wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45587/
> -----------------------------------------------------------
>
> (Updated April 1, 2016, 3:20 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Oliver Szabo, and Sebastian Toader.
>
>
> Bugs: AMBARI-15669
> https://issues.apache.org/jira/browse/AMBARI-15669
>
>
> Repository: ambari
>
>
> Description
> -------
>
> AuditLoggerModule was missing when injector is created for SchemaUpgradeHelper. AuditLoggerModule is now added to the injector.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java 89e920d
>
> Diff: https://reviews.apache.org/r/45587/diff/
>
>
> Testing
> -------
>
> I did an upgrade from 2.2.2 to trunk to verify the fix.
>
>
> Thanks,
>
> Daniel Gergely
>
>
Re: Review Request 45587: Upgrade to trunk fails due AuditLogger
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45587/#review126627
-----------------------------------------------------------
Pushed to trunk,
commit 12d19c9f82f66c2db19b72199d29a6691ae398a8
- Alejandro Fernandez
On April 1, 2016, 1:20 p.m., Daniel Gergely wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45587/
> -----------------------------------------------------------
>
> (Updated April 1, 2016, 1:20 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Oliver Szabo, and Sebastian Toader.
>
>
> Bugs: AMBARI-15669
> https://issues.apache.org/jira/browse/AMBARI-15669
>
>
> Repository: ambari
>
>
> Description
> -------
>
> AuditLoggerModule was missing when injector is created for SchemaUpgradeHelper. AuditLoggerModule is now added to the injector.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java 89e920d
>
> Diff: https://reviews.apache.org/r/45587/diff/
>
>
> Testing
> -------
>
> I did an upgrade from 2.2.2 to trunk to verify the fix.
>
>
> Thanks,
>
> Daniel Gergely
>
>
Re: Review Request 45587: Upgrade to trunk fails due AuditLogger
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45587/#review126606
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On April 1, 2016, 1:20 p.m., Daniel Gergely wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45587/
> -----------------------------------------------------------
>
> (Updated April 1, 2016, 1:20 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Oliver Szabo, and Sebastian Toader.
>
>
> Bugs: AMBARI-15669
> https://issues.apache.org/jira/browse/AMBARI-15669
>
>
> Repository: ambari
>
>
> Description
> -------
>
> AuditLoggerModule was missing when injector is created for SchemaUpgradeHelper. AuditLoggerModule is now added to the injector.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java 89e920d
>
> Diff: https://reviews.apache.org/r/45587/diff/
>
>
> Testing
> -------
>
> I did an upgrade from 2.2.2 to trunk to verify the fix.
>
>
> Thanks,
>
> Daniel Gergely
>
>
Re: Review Request 45587: Upgrade to trunk fails due AuditLogger
Posted by Oliver Szabo <os...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45587/#review126579
-----------------------------------------------------------
Ship it!
Ship It!
- Oliver Szabo
On April 1, 2016, 1:20 p.m., Daniel Gergely wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45587/
> -----------------------------------------------------------
>
> (Updated April 1, 2016, 1:20 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Oliver Szabo, and Sebastian Toader.
>
>
> Bugs: AMBARI-15669
> https://issues.apache.org/jira/browse/AMBARI-15669
>
>
> Repository: ambari
>
>
> Description
> -------
>
> AuditLoggerModule was missing when injector is created for SchemaUpgradeHelper. AuditLoggerModule is now added to the injector.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java 89e920d
>
> Diff: https://reviews.apache.org/r/45587/diff/
>
>
> Testing
> -------
>
> I did an upgrade from 2.2.2 to trunk to verify the fix.
>
>
> Thanks,
>
> Daniel Gergely
>
>