[GitHub] [arrow] thisisnic commented on a diff in pull request #13482: ARROW-14989: [R] Update num_rows methods to output doubles not integers to prevent integer overflow

[GitBox <gi...@apache.org>]

thisisnic commented on code in PR #13482:
URL: https://github.com/apache/arrow/pull/13482#discussion_r911375661


##########
r/tests/testthat/test-Table.R:
##########
@@ -696,3 +696,18 @@ test_that("as_arrow_table() errors for invalid input", {
     class = "arrow_no_method_as_arrow_table"
   )
 })
+
+test_that("ARROW-14989: num_rows method not susceptible to integer overflow", {
+  skip_on_cran()
+
+  test_array1 <- Array$create(raw(.Machine$integer.max))

Review Comment:
   Should these tests be removed, as they're just going to slow down test runs because of this line?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org