You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by "Quintin May (JIRA)" <ji...@apache.org> on 2007/08/16 18:49:31 UTC

[jira] Created: (HTTPCLIENT-687) DefaultRedirectHandler does not access correct HttpParams

DefaultRedirectHandler does not access correct HttpParams
---------------------------------------------------------

                 Key: HTTPCLIENT-687
                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-687
             Project: HttpComponents HttpClient
          Issue Type: Bug
          Components: HttpClient
    Affects Versions: 4.0 Alpha 1
            Reporter: Quintin May
            Priority: Critical


In the getLocationURI(HttpResponse, HttpContext) method, the HttpParams for determining REJECT_RELATIVE_REDIRECT and ALLOW_CIRCULAR_REDIRECTS are retrieved with:

HttpParams params = response.getParams();

The response HttpParams do not contain these values, however the request HttpParams do. The correct implementation is:

HttpRequest request = (HttpRequest) context.getAttribute(HttpExecutionContext.HTTP_REQUEST);
HttpParams params = request.getParams();



-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: httpcomponents-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpcomponents-dev-help@jakarta.apache.org


[jira] Updated: (HTTPCLIENT-687) DefaultRedirectHandler does not access correct HttpParams

Posted by "Oleg Kalnichevski (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HTTPCLIENT-687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Oleg Kalnichevski updated HTTPCLIENT-687:
-----------------------------------------

    Fix Version/s: 4.0 Alpha 2

Actually response was supposed to inherit (link to) the request parameters. Anyways, it is still a bug. 

It is nice to know people are experimenting with HttpClient 4.0.

Oleg

> DefaultRedirectHandler does not access correct HttpParams
> ---------------------------------------------------------
>
>                 Key: HTTPCLIENT-687
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-687
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>          Components: HttpClient
>    Affects Versions: 4.0 Alpha 1
>            Reporter: Quintin May
>            Priority: Critical
>             Fix For: 4.0 Alpha 2
>
>
> In the getLocationURI(HttpResponse, HttpContext) method, the HttpParams for determining REJECT_RELATIVE_REDIRECT and ALLOW_CIRCULAR_REDIRECTS are retrieved with:
> HttpParams params = response.getParams();
> The response HttpParams do not contain these values, however the request HttpParams do. The correct implementation is:
> HttpRequest request = (HttpRequest) context.getAttribute(HttpExecutionContext.HTTP_REQUEST);
> HttpParams params = request.getParams();

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: httpcomponents-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpcomponents-dev-help@jakarta.apache.org


[jira] Resolved: (HTTPCLIENT-687) DefaultRedirectHandler does not access correct HttpParams

Posted by "Oleg Kalnichevski (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HTTPCLIENT-687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Oleg Kalnichevski resolved HTTPCLIENT-687.
------------------------------------------

    Resolution: Fixed

Fixed in SVN trunk.

Oleg

> DefaultRedirectHandler does not access correct HttpParams
> ---------------------------------------------------------
>
>                 Key: HTTPCLIENT-687
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-687
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>          Components: HttpClient
>    Affects Versions: 4.0 Alpha 1
>            Reporter: Quintin May
>            Priority: Critical
>             Fix For: 4.0 Alpha 2
>
>
> In the getLocationURI(HttpResponse, HttpContext) method, the HttpParams for determining REJECT_RELATIVE_REDIRECT and ALLOW_CIRCULAR_REDIRECTS are retrieved with:
> HttpParams params = response.getParams();
> The response HttpParams do not contain these values, however the request HttpParams do. The correct implementation is:
> HttpRequest request = (HttpRequest) context.getAttribute(HttpExecutionContext.HTTP_REQUEST);
> HttpParams params = request.getParams();

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: httpcomponents-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpcomponents-dev-help@jakarta.apache.org