You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "vsima (via GitHub)" <gi...@apache.org> on 2026/09/30 21:39:56 UTC
[PR] Return is_favorite on Dag list and Dag responses [airflow]
vsima opened a new pull request, #73992:
URL: https://github.com/apache/airflow/pull/73992
`GET /dags` can filter by `is_favorite` but doesn't return it, so API clients need an extra call per Dag. The private `/ui/dags` already returns it.
This moves `is_favorite` onto `DAGResponse` and sets it on every endpoint that returns one (`GET /dags`, `GET /dags/{dag_id}`, `PATCH /dags/{dag_id}`, `PATCH /dags`), so it is never a wrong default. One batched query per page; query counts go from 4 to 5.
Tests: one per endpoint, each failing without the change.
---
##### Was generative AI tooling used to co-author this PR?
- [X] Yes — Claude Code (Opus 5.5)
Generated-by: Claude Code (Opus 5.5) following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Return is_favorite on Dag list and Dag responses [airflow]
Posted by "vsima (via GitHub)" <gi...@apache.org>.
vsima closed pull request #73992: Return is_favorite on Dag list and Dag responses
URL: https://github.com/apache/airflow/pull/73992
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Return is_favorite on Dag list and Dag responses [airflow]
Posted by "kaxil (via GitHub)" <gi...@apache.org>.
kaxil commented on PR #73992:
URL: https://github.com/apache/airflow/pull/73992#issuecomment-5940181329
What's the use case behind this? `is_favorite` is per-user state, and this puts it on `DAGResponse`, so every public endpoint that returns a Dag (including `PATCH /dags`) starts returning caller-specific data, at the cost of an extra query per page. The description says clients would otherwise need an extra call per Dag, but doesn't name a client or a user who ran into it. Is there an issue or a concrete integration that needs this? Converting to draft until there is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Return is_favorite on Dag list and Dag responses [airflow]
Posted by "vsima (via GitHub)" <gi...@apache.org>.
vsima commented on PR #73992:
URL: https://github.com/apache/airflow/pull/73992#issuecomment-5945282185
Ah, you're totally right, thanks. A single GET /dags?is_favorite=true per page already covers it, so I overstated the cost. Closing this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org