[GitHub] [incubator-yunikorn-web] wilfred-s commented on a change in pull request #28: YUNIKORN-8: Pull application and container history from core

[GitBox <gi...@apache.org>]

wilfred-s commented on a change in pull request #28: YUNIKORN-8: Pull application and container history from core
URL: https://github.com/apache/incubator-yunikorn-web/pull/28#discussion_r400157179
 
 

 ##########
 File path: src/app/components/cluster-info/cluster-info.component.ts
 ##########
 @@ -59,8 +61,13 @@ export class ClusterInfoComponent implements OnInit {
         this.updateContainerStatusData(data);
       });
 
-    this.jobHistoryData = this.generateHistoryData();
-    this.containerHistoryData = this.generateHistoryData();
+    this.scheduler.fetchAppHistory().subscribe(data => {
+      this.jobHistoryData = this.getAreaChartData(data);
 
 Review comment:
   Can we rename this to app history data? 
   Or should we do it similarly to what we did in core/shim and change from job to app in a separate jira?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services