You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2021/12/20 08:21:33 UTC

[GitHub] [fineract] francisguchie commented on pull request #1984: FINERACT-1431:PassportDropDown-in-ClientIdentifier

francisguchie commented on pull request #1984:
URL: https://github.com/apache/fineract/pull/1984#issuecomment-997697730


   > @rrpawar96 , this looks fine. Thanks for that change. Could you please move the validation from domain object to validator class?> Also I am just curious, is there a specific reason for not using code-code value table for new drop down?
   
   @rrpawar96 have you addressed @fynmanoj  request. On my side the functional test is working fine 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org