[GitHub] [samza] mynameborat commented on a change in pull request #1044: SAMZA-2204: Consolidate some reflection-related utility methods into a common class

[GitBox <gi...@apache.org>]

mynameborat commented on a change in pull request #1044: SAMZA-2204: Consolidate some reflection-related utility methods into a common class
URL: https://github.com/apache/samza/pull/1044#discussion_r286623336
 
 

 ##########
 File path: samza-core/src/main/scala/org/apache/samza/util/Util.scala
 ##########
 @@ -49,7 +49,10 @@ object Util extends Logging {
 
   /**
    * Instantiate an object of type T from a given className.
+   *
+   * Deprecated: Use [[ReflectionUtil.getObj(String, Class, ClassLoader)]] instead.
 
 Review comment:
   Consumers of this method are not aware of which class loader to use. Can you add a recommendation here as part of deprecated notes?
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services