You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@iggy.apache.org by "chiradip (via GitHub)" <gi...@apache.org> on 2025/11/29 23:15:05 UTC
[PR] feat(server) [iggy]
chiradip opened a new pull request, #2418:
URL: https://github.com/apache/iggy/pull/2418
# **PR Submission Guidelines**
**Please remove this entire section before submitting your PR.**
**This section is only for your reference.**
🙌 **Thank you for contributing to `iggy`!**
To help us incorporate your changes efficiently, please adhere to the following guidelines:
## General Coding Remarks
- **Code Formatting**: Run `cargo fmt` to ensure your code adheres to the project's style.
- **Code Linting**: Run `cargo clippy --all-targets --all-features -- -D warnings` to make sure your code is lint-free.
- **Unit Testing**: Write or update unit tests to cover your changes.
- **Integration Testing**: Write or update integration tests to cover your changes.
- **Project Structure**: Follow the `iggy` project's structure and coding style.
- **Build Integrity**: Ensure your code compiles and runs error-free.
- **Check unused dependencies**: Run `cargo machete` to make sure no unused dependencies made their way into your changeset.
- **Sort dependencies**: Run `cargo sort --workspace` so that the content of the toml files stay ordered.
## Commit Message Rules
- **Description**: Provide a concise description of the changes.
- **Style**: Use an imperative style in the subject line (e.g., "Fix bug" rather than "Fixed bug" or "Fixes bug").
- **Brevity**: Keep the subject line under 80 characters.
- **Rationale**: Explain the 'why' and 'what' of your changes in the summary.
- **Details**: Use the body to elaborate on the 'how' of your changes.
- **Context**: Include 'before' and 'after' scenarios if applicable.
- **References**: Link any relevant issues or PRs in the message body.
**Remember:** Your contribution is essential to the success of `iggy`. Please ensure that your PR conforms to these guidelines for a swift and smooth integration process.
Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(server): Add Cache-Friendly In-Memory Segment Index [iggy]
Posted by "chiradip (via GitHub)" <gi...@apache.org>.
chiradip commented on PR #2418:
URL: https://github.com/apache/iggy/pull/2418#issuecomment-3704449937
> @chiradip what are next steps for this PR? I see that you have some base, but it's not properly integrated with rest of repo.
What do you mean @hubcio ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(server): Add Cache-Friendly In-Memory Segment Index [iggy]
Posted by "chiradip (via GitHub)" <gi...@apache.org>.
chiradip commented on PR #2418:
URL: https://github.com/apache/iggy/pull/2418#issuecomment-3705581556
Keep this PR open, let me work on this when I get time. The suggestions are understood accepted.
Regarding performance gain - there is performance gain but I need to formally do more and see whether they are significant enough. I need to refresh my memory on this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(server): Add Cache-Friendly In-Memory Segment Index [iggy]
Posted by "hubcio (via GitHub)" <gi...@apache.org>.
hubcio commented on PR #2418:
URL: https://github.com/apache/iggy/pull/2418#issuecomment-3636760829
@chiradip it's a toggler test :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(server): Add Cache-Friendly In-Memory Segment Index [iggy]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #2418: feat(server): Add Cache-Friendly In-Memory Segment Index
URL: https://github.com/apache/iggy/pull/2418
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(server): Add Cache-Friendly In-Memory Segment Index [iggy]
Posted by "chiradip (via GitHub)" <gi...@apache.org>.
chiradip commented on PR #2418:
URL: https://github.com/apache/iggy/pull/2418#issuecomment-3614646708
@hubcio @numinnex do you guys know what node e2e fail means?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(server): Add Cache-Friendly In-Memory Segment Index [iggy]
Posted by "hubcio (via GitHub)" <gi...@apache.org>.
hubcio commented on PR #2418:
URL: https://github.com/apache/iggy/pull/2418#issuecomment-3705073325
By not properly integrated I mean:
- `slice_by_timestamp()` still uses `binary_search_position_for_timestamp_sync()` - `find_by_timestamp_block_aware()` is not used in production code
- `round_up_to_cache_line()` is used only in test code
also:
- `IndexCacheLineBlock` is in wrong location, this is server-side optimization, should be somewhere in `core/server/src/streaming/segments/indexes`
- benchmark files like `indexes_mut_bench.rs` should be inside `integration` package, also I suggest to convert them to use `criterion`
Lastly, I remember that we were talking that you'll present some measurable gains. Can you comment on that? Did this change yield any measurable performance improvement?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(server): Add Cache-Friendly In-Memory Segment Index [iggy]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #2418:
URL: https://github.com/apache/iggy/pull/2418#issuecomment-3824720569
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs.
If you need a review, please ensure CI is green and the PR is rebased on the latest master. Don't hesitate to ping the maintainers - either @core on Discord or by mentioning them directly here on the PR.
Thank you for your contribution!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(server): Add Cache-Friendly In-Memory Segment Index [iggy]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #2418:
URL: https://github.com/apache/iggy/pull/2418#issuecomment-3863157328
This pull request was automatically closed because it has been inactive for 14 days. Feel free to reopen it if you'd like to continue working on it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(server): Add Cache-Friendly In-Memory Segment Index [iggy]
Posted by "hubcio (via GitHub)" <gi...@apache.org>.
hubcio commented on PR #2418:
URL: https://github.com/apache/iggy/pull/2418#issuecomment-3698927946
@chiradip what are next steps for this PR?
I see that you have some base, but it's not properly integrated with rest of repo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org