You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/02/09 02:18:59 UTC
[GitHub] [arrow] cyb70289 commented on a change in pull request #12354: ARROW-15600: [C++][FlightRPC] Add minimal Flight SQL query example
cyb70289 commented on a change in pull request #12354:
URL: https://github.com/apache/arrow/pull/12354#discussion_r802213342
##########
File path: cpp/examples/arrow/CMakeLists.txt
##########
@@ -84,6 +84,24 @@ if(ARROW_FLIGHT)
EXTRA_SOURCES
"${CMAKE_CURRENT_BINARY_DIR}/helloworld.pb.cc"
"${CMAKE_CURRENT_BINARY_DIR}/helloworld.grpc.pb.cc")
+
+ if(ARROW_FLIGHT_SQL)
+ if(ARROW_GRPC_USE_SHARED)
+ set(FLIGHT_SQL_EXAMPLES_LINK_LIBS arrow_flight_sql_shared)
+ else()
+ set(FLIGHT_SQL_EXAMPLES_LINK_LIBS arrow_flight_sql_static)
+ endif()
+
+ add_arrow_example(flight_sql_example
+ DEPENDENCIES
+ flight_sql_test_server
Review comment:
Ditto
##########
File path: cpp/examples/arrow/CMakeLists.txt
##########
@@ -84,6 +84,24 @@ if(ARROW_FLIGHT)
EXTRA_SOURCES
"${CMAKE_CURRENT_BINARY_DIR}/helloworld.pb.cc"
"${CMAKE_CURRENT_BINARY_DIR}/helloworld.grpc.pb.cc")
+
+ if(ARROW_FLIGHT_SQL)
+ if(ARROW_GRPC_USE_SHARED)
+ set(FLIGHT_SQL_EXAMPLES_LINK_LIBS arrow_flight_sql_shared)
+ else()
+ set(FLIGHT_SQL_EXAMPLES_LINK_LIBS arrow_flight_sql_static)
+ endif()
+
+ add_arrow_example(flight_sql_example
Review comment:
Looks we prefer `-` for executable names, `_` for source names.
Change it to `flight-sql-example`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org