[GitHub] [ozone] smengcl edited a comment on pull request #3007: HDDS-6211. [Docs] Image styling on deployed site does not replicate local builds.

[GitBox <gi...@apache.org>]

smengcl edited a comment on pull request #3007:
URL: https://github.com/apache/ozone/pull/3007#issuecomment-1022667974


   Thanks @JyotinderSingh for the patch.
   
   When I'm verifying the patch locally, I don't really see any change on the page before and after the patch when scaling (shrinking and extending page width, zooming in and out): http://localhost:1313/feature/prefixfso.html
   
   ```bash
   cd hadoop-hdds/docs
   hugo serve
   ```
   
   But I do notice the CSS of class `img-responsive` includes `max-width: 100%`:
   
   ```css
   // Responsive image
   //
   // Keep images from scaling beyond the width of their parents.
   .img-responsive(@display: block) {
     display: @display;
     max-width: 100%; // Part 1: Set a maximum relative to the parent
     height: auto; // Part 2: Scale the height according to the width, otherwise you get stretching
   }
   ```
   
   And the images on the doc site have indeed lost the hard-coded style somehow: https://ozone.apache.org/docs/1.2.1/feature/prefixfso.html
   
   So `img-responsive` seems to be the proper way to do this. I am +1 on this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org