You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/06/17 20:24:09 UTC
[GitHub] [incubator-nuttx] dakejahl opened a new pull request #1268: STM32F412 board support
dakejahl opened a new pull request #1268:
URL: https://github.com/apache/incubator-nuttx/pull/1268
## Summary
This PR adds support for the STM32F412. This has been tested with the NUCLEO-F412ZG board from ST, as well a custom board using the F412CE.
## Impact
The clock tree on the F412 is unique, and therefore I decided to create a new `*rcc.c/h` file such that I don't pollute the common F4 rcc file with even more `#if defined`.
## Testing
#### F412ZG
- UART
- SPI
- CAN
#### F412CE
- UART
- SPI
- CAN
- I2C
- DMA
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] davids5 commented on pull request #1268: STM32F412 board support
Posted by GitBox <gi...@apache.org>.
davids5 commented on pull request #1268:
URL: https://github.com/apache/incubator-nuttx/pull/1268#issuecomment-645947128
@dakejahl the technical side please look into @raiden00pl query.
On the process side: Unfortunately this project has limited the committer's ability to do the right type of merge.
Therefor I need to ask to clean up the commit and comments and force push. See [the link and do's and dont's](https://github.com/nuttx-to-asf/incubator-nuttx/blob/master-pr-add-PR-template/.github/PULL_REQUEST_TEMPLATE.md) you can ignore the rest.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on pull request #1268: STM32F412 board support
Posted by GitBox <gi...@apache.org>.
acassis commented on pull request #1268:
URL: https://github.com/apache/incubator-nuttx/pull/1268#issuecomment-645995169
Congratulations Jacob! Now it is passing in the CI tests. I was going to Merge it when I saw the raiden00pl question about why you created a new file to RCC configuration. Do you think it is possible to use the existing file? @raiden00pl for consistency do you think he could rename stm32f40xxx_rcc.c to stm32f4xxxx_rcc.c ? Also if this RCC is different enough to include many #ifdefs inside stm32f40xxx_rcc.c, then I think it is better to keep it in a different file. What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on pull request #1268: STM32F412 board support
Posted by GitBox <gi...@apache.org>.
acassis commented on pull request #1268:
URL: https://github.com/apache/incubator-nuttx/pull/1268#issuecomment-645622054
> I don't understand how `checkpatch` works. Does it do anything automatically or is the purpose just to show which lines are breaking which rules and then I manually fix them?
Hi Jacob,
checkpatch works similar to the checkpatch from Linux kernel.
If you want to see the issues reported by the "Check / check (pull_request)" just click in Details.
I paste it here to make it easier to you: https://pastebin.com/81qH8anp
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] dakejahl commented on pull request #1268: STM32F412 board support
Posted by GitBox <gi...@apache.org>.
dakejahl commented on pull request #1268:
URL: https://github.com/apache/incubator-nuttx/pull/1268#issuecomment-646863497
I took a quick stab at coalescing the rcc files, I don't have time this week to give the proper focused attention to this task (lots of minor painstaking differences) -- retesting to make sure I don't break anything in the process. Might have time next week.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] raiden00pl merged pull request #1268: STM32F412 board support
Posted by GitBox <gi...@apache.org>.
raiden00pl merged pull request #1268:
URL: https://github.com/apache/incubator-nuttx/pull/1268
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] dakejahl commented on pull request #1268: STM32F412 board support
Posted by GitBox <gi...@apache.org>.
dakejahl commented on pull request #1268:
URL: https://github.com/apache/incubator-nuttx/pull/1268#issuecomment-645617397
I don't understand how `checkpatch` works. Does it do anything automatically or is the purpose just to show which lines are breaking which rules and then I manually fix them?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] raiden00pl commented on pull request #1268: STM32F412 board support
Posted by GitBox <gi...@apache.org>.
raiden00pl commented on pull request #1268:
URL: https://github.com/apache/incubator-nuttx/pull/1268#issuecomment-646168801
Yes, stm32f4xxxx_rcc.c seems to be more appropriate.
From what I looked, the file stm32f40xxx_rcc.c doesn't look so bad when it comes to #ifdefs so I don't really see a reason to create a new file.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] dakejahl commented on pull request #1268: STM32F412 board support
Posted by GitBox <gi...@apache.org>.
dakejahl commented on pull request #1268:
URL: https://github.com/apache/incubator-nuttx/pull/1268#issuecomment-646284297
Alright I'll squash and force push as a single commit. I made the extra rcc.c file because I was trying to keep things straight in my head when doing the bringup, and I found it easier to understand the code without all of the extra preprocessor logic. I can probably consolidate it into the generic rcc file and I'll rename it to be stm32f4xxxx_rcc.c
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] davids5 commented on pull request #1268: STM32F412 board support
Posted by GitBox <gi...@apache.org>.
davids5 commented on pull request #1268:
URL: https://github.com/apache/incubator-nuttx/pull/1268#issuecomment-645609033
@dakejahl - please see the Coding standard formatting. run tools/checkpatch.sh to fix them
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] raiden00pl commented on pull request #1268: STM32F412 board support
Posted by GitBox <gi...@apache.org>.
raiden00pl commented on pull request #1268:
URL: https://github.com/apache/incubator-nuttx/pull/1268#issuecomment-645796028
Hi, could you please explain why you created a new *.c file for RCC configuration ?
From what I see, the clock tree for STM32F412 is not much different from other STM32F4.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] dakejahl commented on pull request #1268: STM32F412 board support
Posted by GitBox <gi...@apache.org>.
dakejahl commented on pull request #1268:
URL: https://github.com/apache/incubator-nuttx/pull/1268#issuecomment-651580166
Thanks everyone!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on pull request #1268: STM32F412 board support
Posted by GitBox <gi...@apache.org>.
acassis commented on pull request #1268:
URL: https://github.com/apache/incubator-nuttx/pull/1268#issuecomment-646914691
Don't worry Jacob, take your time!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis edited a comment on pull request #1268: STM32F412 board support
Posted by GitBox <gi...@apache.org>.
acassis edited a comment on pull request #1268:
URL: https://github.com/apache/incubator-nuttx/pull/1268#issuecomment-645622054
> I don't understand how `checkpatch` works. Does it do anything automatically or is the purpose just to show which lines are breaking which rules and then I manually fix them?
Hi Jacob,
checkpatch works similar to the checkpatch from Linux kernel.
If you want to see the issues reported by the "Check / check (pull_request)" just click in Details.
I paste it here to make it easier to you: https://pastebin.com/raw/F8fVEzen [Link Updated]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] davids5 commented on pull request #1268: STM32F412 board support
Posted by GitBox <gi...@apache.org>.
davids5 commented on pull request #1268:
URL: https://github.com/apache/incubator-nuttx/pull/1268#issuecomment-651183450
@acassis @raiden00pl Any reasons not to merge for your side?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org