You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/09/10 18:51:45 UTC
[GitHub] [druid] jihoonson commented on pull request #10368: Adding the missing sqlQueryContext api
jihoonson commented on pull request #10368:
URL: https://github.com/apache/druid/pull/10368#issuecomment-690618493
Hi @mghosh4, the code change looks good to me, but I think it would be nice to have some test for this class. Would you mind adding one which verifies JSON-serialization? We don't currently have any tests for `DefaultRequestLogEvent`, so you may want to add one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org