You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@submarine.apache.org by GitBox <gi...@apache.org> on 2021/08/13 07:20:13 UTC
[GitHub] [submarine] Kenchu123 opened a new pull request #707: SUBMARINE-975. Create storageClass for database, minio, tensorboard to control persistentVolume
Kenchu123 opened a new pull request #707:
URL: https://github.com/apache/submarine/pull/707
### What is this PR for?
<!-- A few sentences describing the overall goals of the pull request's commits.
First time? Check out the contributing guide - https://submarine.apache.org/contribution/contributions.html
-->
To create persistent volumes, submarine-operator creates persistent volumes with different names depending on the namespace (eg. `submarine-database-pv–default`)
However, we can use storage class to create persistent volumes dynamically and delete them easily.
This will be implemented only on the submarine operator. Besides, only minikube support the current storage class provisioner, and volumes can only be in the host (nfs not supported).
### What type of PR is it?
[Improvement]
### Todos
- [x] Add storage class
- [x] Modify operator to create persistent volume claim with storage class name
- [x] Remove persistent volume creation in operator
### What is the Jira issue?
<!-- * Open an issue on Jira https://issues.apache.org/jira/browse/SUBMARINE/
* Put link here, and add [SUBMARINE-*Jira number*] in PR title, eg. `SUBMARINE-23. PR title`
-->
https://issues.apache.org/jira/browse/SUBMARINE-975
### How should this be tested?
<!--
* First time? Setup Travis CI as described on https://submarine.apache.org/contribution/contributions.html#continuous-integration
* Strongly recommended: add automated unit tests for any new or changed behavior
* Outline any manual steps to test the PR here.
-->
Follow submarine-operator instructions.
### Screenshots (if appropriate)
https://user-images.githubusercontent.com/17617373/129319157-5923ebcf-cdf4-45ae-b18c-e3cc0eb45b16.mov
### Questions:
* Do the license files need updating? No
* Are there breaking changes for older versions? No
* Does this need new documentation? No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] Kenchu123 commented on pull request #707: SUBMARINE-975. Create storageClass for database, minio, tensorboard to control persistentVolume
Posted by GitBox <gi...@apache.org>.
Kenchu123 commented on pull request #707:
URL: https://github.com/apache/submarine/pull/707#issuecomment-898895056
> @Kenchu123 I think you can provide a named template (_helper.tpl file) in the template file. It can create the default value for the provisioner and can be customized by users. With `named template`, users and developers can set their own environment variable like `helm install --set <your env> ...`.
> more info: https://helm.sh/docs/chart_template_guide/named_templates/
Thanks. This is what I'm looking for~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] asfgit closed pull request #707: SUBMARINE-975. Create storageClass for database, minio, tensorboard to control persistentVolume
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #707:
URL: https://github.com/apache/submarine/pull/707
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] asfgit closed pull request #707: SUBMARINE-975. Create storageClass for database, minio, tensorboard to control persistentVolume
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #707:
URL: https://github.com/apache/submarine/pull/707
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] Kenchu123 commented on pull request #707: SUBMARINE-975. Create storageClass for database, minio, tensorboard to control persistentVolume
Posted by GitBox <gi...@apache.org>.
Kenchu123 commented on pull request #707:
URL: https://github.com/apache/submarine/pull/707#issuecomment-898894908
> Thank @Kenchu123 for your contribution! I have a question. Why do we need the file`storageclass.yaml`? In my opinion, the hard-coded StorageClass names cannot support multi-tenancy. To elaborate, in your implementation, two Submarine services in two different namespaces will use the same name "submarine-database-sc" as the name of their DB StorageClass.
Storage class is like an agent for controlling persistent volumes. Take submarine as an example, for submarine servers in different namespaces, they will have different persistent volume claims, so the storage class's provisioner will then create different persistent volumes for each submarine server.
Besides, the storage class is cluster-scoped, so I think components in different namespaces can use the same storage class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] Kenchu123 commented on pull request #707: SUBMARINE-975. Create storageClass for database, minio, tensorboard to control persistentVolume
Posted by GitBox <gi...@apache.org>.
Kenchu123 commented on pull request #707:
URL: https://github.com/apache/submarine/pull/707#issuecomment-899014415
> @Kenchu123 Thank you for your explanation! I got the idea. In addition, will you add a named template in this PR?
I think I'll make a new pull request. The named template needs some tests and document modification.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] kevin85421 commented on pull request #707: SUBMARINE-975. Create storageClass for database, minio, tensorboard to control persistentVolume
Posted by GitBox <gi...@apache.org>.
kevin85421 commented on pull request #707:
URL: https://github.com/apache/submarine/pull/707#issuecomment-898982665
@Kenchu123 Thank you for your explanation! I got the idea. In addition, will you add a named template in this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] KUAN-HSUN-LI commented on pull request #707: SUBMARINE-975. Create storageClass for database, minio, tensorboard to control persistentVolume
Posted by GitBox <gi...@apache.org>.
KUAN-HSUN-LI commented on pull request #707:
URL: https://github.com/apache/submarine/pull/707#issuecomment-898886604
@Kenchu123 I think you can provide a named template (_helper.tpl file) in the template file. It can create the default value for the provisioner and can be customized by users. With `named template`, users and developers can set their own environment variable like `helm install --set <your env> ...`.
more info: https://helm.sh/docs/chart_template_guide/named_templates/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org