[GitHub] [arrow-rs] alamb commented on a diff in pull request #4343: Fix MutableArrayData::extend_nulls (#1230)

["alamb (via GitHub)" <gi...@apache.org>]

alamb commented on code in PR #4343:
URL: https://github.com/apache/arrow-rs/pull/4343#discussion_r1214506345


##########
arrow-data/src/transform/mod.rs:
##########
@@ -624,13 +633,18 @@ impl<'a> MutableArrayData<'a> {
     }
 
     /// Extends this [MutableArrayData] with null elements, disregarding the bound arrays
+    ///
+    /// # Panics
+    ///
+    /// Panics if [`MutableArrayData`] not created with `use_nulls` or nullable source arrays
+    ///
     pub fn extend_nulls(&mut self, len: usize) {
-        // TODO: null_buffer should probably be extended here as well

Review Comment:
   classic TODO



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org