You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2018/01/19 19:55:26 UTC

[GitHub] eolivelli commented on a change in pull request #1022: Only run integration tests with -DintegrationTests

eolivelli commented on a change in pull request #1022: Only run integration tests with -DintegrationTests
URL: https://github.com/apache/bookkeeper/pull/1022#discussion_r162717529
 
 

 ##########
 File path: tests/integration-tests-base/pom.xml
 ##########
 @@ -63,6 +63,8 @@
         <groupId>org.apache.maven.plugins</groupId>
         <artifactId>maven-surefire-plugin</artifactId>
         <configuration>
+          <!-- only run tests when -DintegrationTests is specified //-->
+          <skipTests>true</skipTests>
 
 Review comment:
   Wouldn't it be better to use failsafe and do not run on test goal but with verify?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services