[jira] [Commented] (PHOENIX-3351) Implement TODOs in PhoenixTableModify#upsert to allow writes to tenant specific tables

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PHOENIX-3351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15811644#comment-15811644 ] 

Hadoop QA commented on PHOENIX-3351:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12846304/PHOENIX-3351_master.patch
  against master branch at commit d8f4594989c0b73945aaffec5649a0b62ac59724.
  ATTACHMENT ID: 12846304

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:red}-1 javadoc{color}.  The javadoc tool appears to have generated 43 warning messages.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than 100:
    +    public static MutationState upsertSelect(StatementContext childContext, TableRef tableRef, RowProjector projector,
+            ResultIterator iterator, int[] columnIndexes, int[] pkSlotIndexes, boolean useServerTimestamp, boolean prefixSysColValues) throws SQLException {
+                setValues(values, pkSlotIndexes, columnIndexes, table, mutation, statement, useServerTimestamp, indexMaintainer, viewConstants, null, numSplColumns);
+            MutationState state = upsertSelect(childContext, tableRef, projector.cloneIfNecessary(), iterator, columnIndexes, pkSlotIndexes, useSeverTimestamp, false);
+                        return upsertSelect(new StatementContext(statement), tableRef, projector, iterator, columnIndexes, pkSlotIndexes, useServerTimestamp, false);
+                setValues(values, pkSlotIndexes, columnIndexes, table, mutation, statement, useServerTimestamp, indexMaintainer, viewConstants, onDupKeyBytes, 0);

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/722//testReport/
Javadoc warnings: https://builds.apache.org/job/PreCommit-PHOENIX-Build/722//artifact/patchprocess/patchJavadocWarnings.txt
Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/722//console

This message is automatically generated.

> Implement TODOs in PhoenixTableModify#upsert to allow writes to tenant specific tables
> --------------------------------------------------------------------------------------
>
>                 Key: PHOENIX-3351
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3351
>             Project: Phoenix
>          Issue Type: Sub-task
>            Reporter: Rajeshbabu Chintaguntla
>            Assignee: Rajeshbabu Chintaguntla
>              Labels: calcite
>         Attachments: PHOENIX-3351.patch, PHOENIX-3351_WIP.patch, PHOENIX-3351_master.patch
>
>
> While running UDF IT tests came across this TODO which is necessary to implement for tenant specific, local or view indexes tests to pass.
> {noformat}
>             // TODO TenantId, ViewIndexId, UpdatableViewColumns
>             final List<PColumn> mappedColumns = targetTable.tableMapping.getMappedColumns();
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)