You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@superset.apache.org by GitBox <gi...@apache.org> on 2017/10/24 18:19:55 UTC

[GitHub] graceguo-supercat closed pull request #3711: fix the slice permission issue after user click-edit new slice title

graceguo-supercat closed pull request #3711: fix the slice permission issue after user click-edit new slice title
URL: https://github.com/apache/incubator-superset/pull/3711
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/superset/views/core.py b/superset/views/core.py
index 8cd9a57e07..ca07b8c700 100755
--- a/superset/views/core.py
+++ b/superset/views/core.py
@@ -1212,7 +1212,7 @@ def save_or_overwrite_slice(
             "can_add": slice_add_perm,
             "can_download": slice_download_perm,
             "can_overwrite": is_owner(slc, g.user),
-            'form_data': form_data,
+            'form_data': slc.form_data,
             'slice': slc.data,
         }
 


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services