You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/10/20 05:01:10 UTC
[GitHub] [incubator-seatunnel] TaoZex opened a new pull request, #3149: [Imporve][Connector-V2]Parameter verification for connector V2 elasticsearch sink
TaoZex opened a new pull request, #3149:
URL: https://github.com/apache/incubator-seatunnel/pull/3149
<!--
Thank you for contributing to SeaTunnel! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
## Contribution Checklist
- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-seatunnel/issues).
- Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
- Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
-->
## Purpose of this pull request
The connector V2 elasticsearch sink has no config check, so it is checked.
## Check list
* [ ] Code changed are covered with tests, or it does not need tests for reason:
* [ ] If any new Jar binary package adding in your PR, please add License Notice according
[New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/contribution/new-license.md)
* [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] TaoZex commented on pull request #3149: [Imporve][Connector-V2]Parameter verification for connector V2 elasticsearch sink
Posted by GitBox <gi...@apache.org>.
TaoZex commented on PR #3149:
URL: https://github.com/apache/incubator-seatunnel/pull/3149#issuecomment-1285496468
>
This e2e issue has been assigned: https://github.com/apache/incubator-seatunnel/issues/2819
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] EricJoy2048 commented on pull request #3149: [Imporve][Connector-V2]Parameter verification for connector V2 elasticsearch sink
Posted by GitBox <gi...@apache.org>.
EricJoy2048 commented on PR #3149:
URL: https://github.com/apache/incubator-seatunnel/pull/3149#issuecomment-1285514957
Hi, @TaoZex please update pr title to `[Imporve][Connector-V2][Elasticsearch] Parameter verification for connector V2 elasticsearch sink `
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] Hisoka-X merged pull request #3149: [Imporve][Connector-V2][Elasticsearch] Parameter verification for connector V2 elasticsearch sink
Posted by GitBox <gi...@apache.org>.
Hisoka-X merged PR #3149:
URL: https://github.com/apache/incubator-seatunnel/pull/3149
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] hailin0 commented on pull request #3149: [Imporve][Connector-V2]Parameter verification for connector V2 elasticsearch sink
Posted by GitBox <gi...@apache.org>.
hailin0 commented on PR #3149:
URL: https://github.com/apache/incubator-seatunnel/pull/3149#issuecomment-1285475690
Can you add e2e test for this feature?
reference
https://github.com/apache/incubator-seatunnel/tree/dev/seatunnel-e2e/seatunnel-connector-v2-e2e
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] TaoZex commented on pull request #3149: [Imporve][Connector-V2][Elasticsearch] Parameter verification for connector V2 elasticsearch sink
Posted by GitBox <gi...@apache.org>.
TaoZex commented on PR #3149:
URL: https://github.com/apache/incubator-seatunnel/pull/3149#issuecomment-1285518371
> Hi, @TaoZex please update pr title to `[Imporve][Connector-V2][Elasticsearch] Parameter verification for connector V2 elasticsearch sink `
Thanks，I have updated the pr title.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org