You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/03/22 20:43:54 UTC

[GitHub] [incubator-tvm] zhiics commented on a change in pull request #5126: [WIP][Relay] XXXNode::make to constructor

zhiics commented on a change in pull request #5126: [WIP][Relay] XXXNode::make to constructor
URL: https://github.com/apache/incubator-tvm/pull/5126#discussion_r396138691
 
 

 ##########
 File path: include/tvm/relay/expr.h
 ##########
 @@ -284,18 +285,28 @@ class Let : public Expr {
 class If;
 /*! \brief container of If */
 class IfNode : public ExprNode {
- public:
   /*! \brief The condition */
-  Expr cond;
+  Expr _cond;
 
 Review comment:
   Don't need this change to keep consistent to the used naming style.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services