You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/08/23 14:35:33 UTC
[GitHub] [nifi-minifi-cpp] martinzink opened a new pull request, #1402: MINIFICPP-1919 centos HTTPClientTests fix
martinzink opened a new pull request, #1402:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1402
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [X] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [X] Has your PR been rebased against the latest commit within the target branch (typically main)?
- [X] Is your initial contribution a single, squashed commit?
### For code changes:
- [X] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [X] If applicable, have you updated the LICENSE file?
- [X] If applicable, have you updated the NOTICE file?
### For documentation related changes:
- [X] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] szaszm closed pull request #1402: MINIFICPP-1919 centos HTTPClientTests fix
Posted by GitBox <gi...@apache.org>.
szaszm closed pull request #1402: MINIFICPP-1919 centos HTTPClientTests fix
URL: https://github.com/apache/nifi-minifi-cpp/pull/1402
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] martinzink commented on a diff in pull request #1402: MINIFICPP-1919 centos HTTPClientTests fix
Posted by GitBox <gi...@apache.org>.
martinzink commented on code in PR #1402:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1402#discussion_r952712733
##########
docker/centos/Dockerfile:
##########
@@ -38,7 +38,7 @@ ENV USER minificpp
# gpsd-devel is in EPEL
RUN yum -y install epel-release && yum -y install java-1.8.0-openjdk java-1.8.0-openjdk-devel python36-devel sudo git which maven make libarchive boost-devel lua-devel libusbx-devel libpng-devel \
- gpsd-devel libpcap-devel ccache
+ gpsd-devel libpcap-devel ccache ca-certificates
Review Comment:
ca-certs were expired on the centos 7 docker image
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org