You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/12/05 01:43:57 UTC
[GitHub] [skywalking-python] kezhenxu94 opened a new pull request #95: test: make tests really run on specified Py version and deprecate 3.5 as it's EOL
kezhenxu94 opened a new pull request #95:
URL: https://github.com/apache/skywalking-python/pull/95
<!-- Uncomment the following checklist WHEN AND ONLY WHEN you're adding a new plugin -->
<!--
- [ ] Add a test case for the new plugin
- [ ] Add a component id in [the main repo](https://github.com/apache/skywalking/blob/master/oap-server/server-bootstrap/src/main/resources/component-libraries.yml#L415)
- [ ] Add a logo in [the UI repo](https://github.com/apache/skywalking-rocketbot-ui/tree/master/src/views/components/topology/assets)
- [ ] Rebuild the `requirements.txt` by running `tools/env/build_requirements_(linux|windows).sh`
-->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] kezhenxu94 commented on a change in pull request #95: test: make tests really run on specified Py version and deprecate 3.5 as it's EOL
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #95:
URL: https://github.com/apache/skywalking-python/pull/95#discussion_r536477888
##########
File path: .github/workflows/build.yaml
##########
@@ -40,10 +42,22 @@ jobs:
with:
python-version: ${{ matrix.python-version }}
- name: Set up dependencies
+ if: ${{ matrix.python-version != '3.5' }}
run: make setup install
- name: Lint codes
+ if: ${{ matrix.python-version != '3.5' }}
run: make lint
- name: Check license header
+ if: ${{ matrix.python-version != '3.5' }}
run: make license
- name: Run unit tests
+ if: ${{ matrix.python-version != '3.5' }}
Review comment:
We need this to make it pass the check status first
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] kezhenxu94 merged pull request #95: test: make tests really run on specified Py version and deprecate 3.5 as it's EOL
Posted by GitBox <gi...@apache.org>.
kezhenxu94 merged pull request #95:
URL: https://github.com/apache/skywalking-python/pull/95
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org